Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review isbn-hyphenate dependency #16

Open
rhigman opened this issue Jun 13, 2024 · 0 comments
Open

Review isbn-hyphenate dependency #16

rhigman opened this issue Jun 13, 2024 · 0 comments

Comments

@rhigman
Copy link
Member

rhigman commented Jun 13, 2024

isbn_hyphenate library hasn't been updated in several years, and while it works well, this means it doesn't include the latest ISBN range information.

The maintainer has provided information in the README on how to update the ranges locally, but hasn't responded to issues/PRs on the matter. Currently, thoth-loader users may hit unexpected ISBN errors, the only workaround being this local package update.

We could consider switching to a different library, or to a more active fork of the library (perhaps creating our own).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant