Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add circleci pipeline to publish the docker image to docker hub #21

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

jordipiqueselles
Copy link
Collaborator

The TM org has a circleci context called "conntest-dockerhub-release" which is already configured to with the necessary credentials to push images to TM's docker hub.

This commit puts on this new pipeline the responsibility to build and push new docker images to docker hub when we create a new release. The old github actions job that did the same task has been deleted.

@jordipiqueselles jordipiqueselles self-assigned this Jul 11, 2023
@jordipiqueselles jordipiqueselles added the enhancement New feature or request label Jul 11, 2023
Copy link

@jahantech jahantech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jordipiqueselles jordipiqueselles added enhancement New feature or request and removed enhancement New feature or request labels Jul 11, 2023
@jordipiqueselles jordipiqueselles added enhancement New feature or request and removed enhancement New feature or request labels Aug 15, 2023
The TM org has a circleci context called "conntest-dockerhub-release"
which is already configured to with the necessary credentials to push
images to TM's docker hub.

This commit puts on this new pipeline the responsibility to build and
push new docker images to docker hub when we create a new release. The
old github actions job that did the same task has been deleted.
@jordipiqueselles jordipiqueselles added enhancement New feature or request and removed enhancement New feature or request labels Aug 15, 2023
@jordipiqueselles jordipiqueselles merged commit 2bd0a2f into main Aug 15, 2023
1 check passed
@jordipiqueselles jordipiqueselles deleted the jordi/adapt-to-TM branch August 15, 2023 19:38
jordipiqueselles pushed a commit that referenced this pull request May 31, 2024
This commit reverts
#21 so we use
Github Actions again to build and publish the docker images, now that
some of the actions related to building docker images have been
whitelisted in the ThoughtMachine org.

The docker images built as part of a release are published to ghcr.
jordipiqueselles pushed a commit that referenced this pull request May 31, 2024
This commit reverts
#21 so we use
Github Actions again to build and publish the docker images, now that
some of the actions related to building docker images have been
whitelisted in the ThoughtMachine org.

The docker images built as part of a release are published to ghcr.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants