Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update plugin docs versions #3298

Conversation

samwestmoreland
Copy link
Contributor

@samwestmoreland samwestmoreland commented Nov 19, 2024

This replaces the docs plugin version lint action with a cron job that runs every morning at 9 that should create a pull request to update the versions if needed. Not really sure how to test it!

Copy link
Contributor

@toastwaffle toastwaffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you been able to test this at all?

.github/workflows/plugindocs-update.yml Outdated Show resolved Hide resolved
on:
schedule:
- cron: '0 9 * * *'
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this line do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That apparently allows manual triggering of the action

@samwestmoreland samwestmoreland force-pushed the docs-versions-auto-update branch from 62103a1 to a2dabed Compare November 19, 2024 16:19
@samwestmoreland
Copy link
Contributor Author

Have you been able to test this at all?

I haven't... yolo? Will revert if it's not working!

@toastwaffle
Copy link
Contributor

Have you been able to test this at all?

Oh, I just saw your "Not really sure how to test it!" comment. In theory you could save (most of) the shell commands as a script and run it locally, but practically I don't think this can do much harm so we can just test "in prod" as it were

@samwestmoreland
Copy link
Contributor Author

Ah good point! The file update part at least seems to do the job:

$ git diff
diff --git a/docs/BUILD b/docs/BUILD
index f8505d5dd..105daf7dd 100644
--- a/docs/BUILD
+++ b/docs/BUILD
@@ -57,9 +57,9 @@ genrule(

 # Plugin versions to pull the docs from
 plugins = {
-    "python": "v1.7.0",
-    "java": "v0.4.0",
-    "go": "v1.17.3",
+    "python": "v1.12.1",
+    "java": "v0.4.2",
+    "go": "v1.21.5",
     "cc": "v0.4.0",
     "shell": "v0.2.0",
     "go-proto": "v0.3.0",

@samwestmoreland samwestmoreland merged commit f6c545b into thought-machine:master Nov 19, 2024
9 of 12 checks passed
@samwestmoreland samwestmoreland deleted the docs-versions-auto-update branch November 19, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants