Skip to content

Latest commit

 

History

History
68 lines (43 loc) · 2.74 KB

README.md

File metadata and controls

68 lines (43 loc) · 2.74 KB

Refactoring / Extract Validator

Hey there! We're thoughtbot, a design and development consultancy that brings your digital product ideas to life. We also love to share what we learn.

This coding exercise comes from Upcase, the online learning platform we run. It's part of the Refactoring course and is just one small sample of all the great material available on Upcase, so be sure to visit and check out the rest.

Exercise Intro

In this exercise, you'll be breaking out a validator for phone numbers in the Person class. Currently the validator is a lengthy regular expression (credit: stack overflow) that matches the North American Numbering Plan (NANP) standards and includes the ability to use extensions.

Don't let the complexity of the regex intimidate you; it works as any other regex would in a validation and trying to understand how it works is a great exercise in and of itself.

Instructions

To start, you'll want to clone and run the setup script for the repo

git clone [email protected]:thoughtbot-upcase-exercises/extract-validator.git
cd extract-validator
bin/setup

Extract a new phone number validator from Person (located at lib/person.rb). Make sure to write tests for the new validator as you go.

In the end your code should be able to be called in-line as name_of_validator: true.

Make sure all tests are passing by running:

rake

Featured Solution

Check out the featured solution branch to see the approach we recommend for this exercise.

Forum Discussion

If you find yourself stuck, be sure to check out the associated Upcase Forum discussion for this exercise to see what other folks have said.

Next Steps

When you've finished the exercise, head on back to the Refactoring course to find the next exercise, or explore any of the other great content on Upcase.

License

extract-validator is Copyright © 2015-2018 thoughtbot, inc. It is free software, and may be redistributed under the terms specified in the LICENSE file.

Credits

thoughtbot

This exercise is maintained and funded by thoughtbot, inc.

The names and logos for Upcase and thoughtbot are registered trademarks of thoughtbot, inc.