Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Ensure callbacks only run once per instance. #1712

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BugFix: Ensure callbacks only run once per instance. #1712

wants to merge 1 commit into from

Conversation

CodeMeister
Copy link

@CodeMeister CodeMeister commented Nov 4, 2024 •
edited
Loading

Fixes: #1703

CallbacksObserver refactored to ignore an individual callback that has already been run on the given instance.

EXAMPLE

factory :user do
  name { "Jane" }

  trait :trait_a do
    trait_b
  end

  trait :trait_b do
    after(:build) { |user| user.name += " Doe" }
  end
end

user = build(:user, :trait_a, :trait_b)

BEFORE:
user.name #=> "Jane Doe Doe"

AFTER:
user.name #=> "Jane Doe"

See issue: #1703 for the full issue.

@CodeMeister
Ensure callbacks only run once per instance.
0a58b14 
CallbacksObserver refactored to ignore an individual
callback that has already been run on the given instance.

EXAMPLE

factory :user do
  name { "Jane" }

  trait :trait_a do
    trait_b
  end

  trait :trait_b do
    after(:build) { |user| user.name += " Doe" }
  end
end

user = build(:user, :trait_a, :trait_b)

BEFORE:
user.name #=> "Jane Doe Doe"

AFTER:
user.name #=> "Jane Doe"
@CodeMeister CodeMeister mentioned this pull request Nov 4, 2024
Open
@CodeMeister CodeMeister changed the title Ensure callbacks only run once per instance. BugFix: Ensure callbacks only run once per instance. Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahraqueld sarahraqueld Awaiting requested review from sarahraqueld sarahraqueld is a code owner

@smaboshe smaboshe Awaiting requested review from smaboshe smaboshe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Traits that imply other ones can cause double running of callbacks
1 participant
@CodeMeister