Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not include empty aliases in the compressed scopes #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wandersoncferreira
Copy link
Contributor

@wandersoncferreira wandersoncferreira commented Dec 8, 2022

Previously to this PR an empty entry in the scopes alias dictionary would be added to the compressed scopes result:

(is (= #{"+admin" "+baz" "x" "+foo"}
         (sut/scopes-compress #{"foo" "bar" "baz" "x"}
                              {"+admin" #{"foo" "bar"}
                               "+baz" #{"baz"}
                               "+foo" #{}})))

An additional check in scopes compression fixed it.

Copy link
Contributor

@yogsototh yogsototh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants