mobile: quic crashes on start-stop-start cycle

[iwanbk]

On Android (and probably on iOS as well), latest mycelium crashed on start-stop-start cycle.

steps to reproduce:

• start android mycelium
• stop
• start again

Crash message doesn't really point out to quic.
But it is fixed when we force is_private_net var to true

mycelium/mycelium/src/peer_manager.rs

Line 171 in ee34c14

let is_private_net = private_network_config.is_some();

Do we need QUIC on mobile device?
If no, maybe we can disable it as well.

In case we disable it, i think we still need to fix it because this crashes mean there is some process that is not gfacefully shut down

[iwanbk]

On Android (and probably on iOS as well)

i found that it doesn't crash on iOS

[LeeSmet]

This is rather strange that it only crashes on quic sockets on android. Regardless given that it happens on a second start, I feel that it's caused by not properly cleaning up when the process is done. Mycelium basically spawns a bunch of background tasks which run forever. Up until now, this was fine, since on desktop, if the node exits, we just exit the whole process.

[iwanbk]

Up until now, this was fine, since on desktop, if the node exits, we just exit the whole process.

FYI, it was fine when i'm working on this PR.
#239

So, it broke after/around that time

[LeeSmet]

@iwanbk I assume this is working properly now?

[iwanbk]

@iwanbk I assume this is working properly now?

i haven't tested it yet because i disable QUIC now.
will test it next week.

[LeeSmet]

@iwanbk any update?

[iwanbk]

oh, sorry, i forgot, will do it tomorrow.

[iwanbk]

@LeeSmet it still doesn't work,
but i don't think it is still a crash, looks like a different issue:

• second start doesn't crash, but ping doesn't work
• second stop failed, not responding

Do you have other fix than?
4bfb834

Anyway, we don't use QUIC on myceliumflut, so this issue doesn't block anything.

[iwanbk]

btw, this is what i did to enable quic

#git diff mobile/
diff --git a/mobile/src/lib.rs b/mobile/src/lib.rs
index dd6334b..a0e31ce 100644
--- a/mobile/src/lib.rs
+++ b/mobile/src/lib.rs
@@ -90,7 +90,7 @@ pub async fn start_mycelium(peers: Vec<String>, tun_fd: i32, priv_key: Vec<u8>)
         peers: endpoints,
         no_tun: false,
         tcp_listen_port: DEFAULT_TCP_LISTEN_PORT,
-        quic_listen_port: None,
+        quic_listen_port: Some(DEFAULT_TCP_LISTEN_PORT),
         peer_discovery_port: None, // disable multicast discovery
         #[cfg(any(
             target_os = "linux",

[iwanbk]

I proposes to close this issue for these reasons:

• we don't use it on android & iphone
• if we want to fix it properly, we have to test the functionality as well. Which pointless because we don't use it.

Except that we want to enable QUIC on android&iphone, which is not the case AFAIK