From 8786835496cd095988482e787a85f288752f145a Mon Sep 17 00:00:00 2001 From: Kamil Pyszkowski Date: Wed, 15 Nov 2023 12:01:41 +0100 Subject: [PATCH 1/4] Added TODO comment Bug with false positive "Unminting in progress" status --- src/pages/tBTC/Bridge/UnmintDetails.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/pages/tBTC/Bridge/UnmintDetails.tsx b/src/pages/tBTC/Bridge/UnmintDetails.tsx index ceb7f3b60..01cf23a75 100644 --- a/src/pages/tBTC/Bridge/UnmintDetails.tsx +++ b/src/pages/tBTC/Bridge/UnmintDetails.tsx @@ -183,6 +183,10 @@ export const UnmintDetails: PageComponent = () => { const timelineBadgeBgColor = useColorModeValue("white", "brand.800") + // TODO: Resolve bug with false positive "Unminting in progress" status + // Plausible solution: fallback conditional rendering to the + // `shouldForceIsProcessCompleted` value + return ( Date: Wed, 15 Nov 2023 14:35:40 +0100 Subject: [PATCH 2/4] Apply fix for the bug Extended render condition to include `shouldForceIsProcessCompleted` boolean --- src/pages/tBTC/Bridge/UnmintDetails.tsx | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/pages/tBTC/Bridge/UnmintDetails.tsx b/src/pages/tBTC/Bridge/UnmintDetails.tsx index 01cf23a75..6a5ce3d39 100644 --- a/src/pages/tBTC/Bridge/UnmintDetails.tsx +++ b/src/pages/tBTC/Bridge/UnmintDetails.tsx @@ -202,9 +202,13 @@ export const UnmintDetails: PageComponent = () => { - {!shouldDisplaySuccessStep && ( + {!(shouldDisplaySuccessStep || shouldForceIsProcessCompleted) && ( {" "} - In progress... From bc39cac088af4f3b5e164120d909cd934656dbf3 Mon Sep 17 00:00:00 2001 From: Kamil Pyszkowski Date: Wed, 15 Nov 2023 14:38:13 +0100 Subject: [PATCH 3/4] Remove TODO comment This reverts commit 8786835496cd095988482e787a85f288752f145a. --- src/pages/tBTC/Bridge/UnmintDetails.tsx | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/pages/tBTC/Bridge/UnmintDetails.tsx b/src/pages/tBTC/Bridge/UnmintDetails.tsx index 6a5ce3d39..370c4550a 100644 --- a/src/pages/tBTC/Bridge/UnmintDetails.tsx +++ b/src/pages/tBTC/Bridge/UnmintDetails.tsx @@ -183,10 +183,6 @@ export const UnmintDetails: PageComponent = () => { const timelineBadgeBgColor = useColorModeValue("white", "brand.800") - // TODO: Resolve bug with false positive "Unminting in progress" status - // Plausible solution: fallback conditional rendering to the - // `shouldForceIsProcessCompleted` value - return ( Date: Tue, 21 Nov 2023 10:13:30 +0100 Subject: [PATCH 4/4] Propagate the fix in more places There are more places in code where the same bug might occur. --- src/pages/tBTC/Bridge/UnmintDetails.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pages/tBTC/Bridge/UnmintDetails.tsx b/src/pages/tBTC/Bridge/UnmintDetails.tsx index 370c4550a..a410727f7 100644 --- a/src/pages/tBTC/Bridge/UnmintDetails.tsx +++ b/src/pages/tBTC/Bridge/UnmintDetails.tsx @@ -188,7 +188,9 @@ export const UnmintDetails: PageComponent = () => { as={BridgeProcessDetailsCard} spacing="4" // @ts-ignore - isProcessCompleted={shouldDisplaySuccessStep} + isProcessCompleted={ + shouldDisplaySuccessStep || shouldForceIsProcessCompleted + } > {_isFetching && } @@ -345,7 +347,7 @@ export const UnmintDetails: PageComponent = () => { ))} - {!shouldDisplaySuccessStep && ( + {!(shouldDisplaySuccessStep || shouldForceIsProcessCompleted) && (