Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of taproot addresses on the Unmint form needs improvement #760

Open
michalinacienciala opened this issue Jun 7, 2024 · 0 comments · May be fixed by #785
Open

Handling of taproot addresses on the Unmint form needs improvement #760

michalinacienciala opened this issue Jun 7, 2024 · 0 comments · May be fixed by #785
Labels

Comments

@michalinacienciala
Copy link
Contributor

I noticed several issues with handling of the situation when user provides a taproot address in the BTC Address field on the Unmint form. Generally, the taproot addresses should not be allowed.

  1. When the field is empty and user enters the taproot address (for example tb1p9vqac4a6lyda7zhvpw9z4qtxjx8ase9c82td4q9j8arlhrl0ujjs97z4az, on testnet), the field gets highlighted in red (OK), but the error message is not descriptive: Required. (NOOK).

  2. The Unmint button is active despite the fact that user provided unsupported address.

  3. Proceeding with the unmint after providing taproot address results in warnings and errors thrown in the console, but there is no information about the error in the dapp and the spinning wheel on the unmint button spins indefinitely.

Screen.Recording.2024-06-07.at.15.30.46.mov
@evandrosaturnino evandrosaturnino linked a pull request Nov 27, 2024 that will close this issue
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant