Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WalletConnect is not connecting with Safe #768

Closed
evandrosaturnino opened this issue Jul 16, 2024 · 0 comments · Fixed by #769
Closed

WalletConnect is not connecting with Safe #768

evandrosaturnino opened this issue Jul 16, 2024 · 0 comments · Fixed by #769
Assignees
@evandrosaturnino
Labels
Bug

Comments

@evandrosaturnino
Copy link
Collaborator

It is not connecting WalletConnect with Safe
image
@evandrosaturnino evandrosaturnino self-assigned this Jul 16, 2024
@evandrosaturnino evandrosaturnino changed the title WalletConnect is not connecting with safe WalletConnect is not connecting with Safe Jul 16, 2024
@evandrosaturnino evandrosaturnino mentioned this issue Jul 19, 2024
Merged
6 tasks
michalsmiarowski added a commit that referenced this issue Jul 30, 2024
@michalsmiarowski
Merge pull request #769 from threshold-network/fix-wallet-connect-upd…
4f4475b 
…ate-issue

Fix update handler validation

## Description

A bug was identified when connecting WalletConnect to Gnosis Safe via the wc
pairing API: Shortly after a user connects their Gnosis Safe vault to the app,
the connection was disconnected. 
Upon investigation, it was discovered that the connection between WalletConnect
and Gnosis Safe was being interrupted due to the chainId format generated after
connecting to Gnosis Safe. This triggered an update that disrupted the
connection because of the way the update validation was structured in App.tsx.

Depending on the format in which the chainId is being passed by a 3rd party
service, it may trigger an update. To handle these edge cases, this PR aims to
add a more comprehensive validation method similarly to what has already been
done previously in the commit
[@3ca72b93ca72b9](3ca72b9).

- [X] - [fix update handler validation](5d0e455)

## Type of change

- [x] 🐛 Bug fix (Non-breaking Change: Fixes an issue)
- [ ]  🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
- [ ]  💅 New Feature (Breaking/Non-breaking Change)

## Notice

- [x] Have you checked to ensure there aren't other open
[Pull Requests](https://github.com/shapeshift/web/pulls) for the same update/change?

## Issue (if applicable)

closes #768

## Pull Request Type

- [x] New Feature (Breaking/Non-breaking Change)
@michalsmiarowski michalsmiarowski mentioned this issue Jul 30, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evandrosaturnino evandrosaturnino

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix update handler validation threshold-network/token-dashboard
1 participant
@evandrosaturnino