Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external links to sub navigation menu #777

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

evandrosaturnino
Copy link
Collaborator

Description

Add external links to the sub navigation menu - Needed initially to include tBTCScan external link.

Type of change

  • 💅 New Feature (Breaking/Non-breaking Change)
  • 🐛 Bug fix (Non-breaking Change: Fixes an issue)
  • 🛠️ Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..

Notice

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Issue (if applicable)

closes #776

Screenshots (if applicable)

image

Pull Request Type

  • New Feature (Breaking/Non-breaking Change)

Copy link

@somaweb3
Copy link

Thanks for the tbtcscan redirect, the changes look good.

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two non-blocking comments. Let me know if we want to address them before the merge.

src/components/SubNavigationPills/index.tsx Outdated Show resolved Hide resolved
src/components/Link/index.tsx Outdated Show resolved Hide resolved
Copy link

Copy link
Contributor

@michalsmiarowski michalsmiarowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@evandrosaturnino evandrosaturnino merged commit 8264be8 into main Aug 23, 2024
5 checks passed
@evandrosaturnino evandrosaturnino deleted the add-external-links-to-sub-navigation-menu branch August 23, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tBTC Explorer menu link
3 participants