Add TACo commitment checks and alerts when topping up or de-authing #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview uploaded to https://preview.dashboard.test.threshold.network/topup/index.html. |
1 similar comment
|
Preview uploaded to https://preview.dashboard.test.threshold.network/topup/index.html. |
arjunhassard
previously approved these changes
Jan 30, 2024
src/pages/Staking/AuthorizeStakingApps/AuthorizeApplicationsCardCheckbox/index.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Arjun Hassard <[email protected]>
|
Preview uploaded to https://preview.dashboard.test.threshold.network/topup/index.html. |
kpyszkowski
reviewed
Mar 18, 2024
| (Number(endCommitment) ?? 0) * 1000 | ||
| ).toLocaleDateString() | ||
| if (isCommited) { | ||
| alert(`You are still committed until ${endCommitmentDate}.`) |
There was a problem hiding this comment.
Have you consider using Toast component here?
Native browser alert doesn't look good and dffers in behaviour in various browsers.
|
Preview uploaded to https://preview.dashboard.test.threshold.network/topup/index.html. |
|
@evandrosaturnino shall we take a look at this again? it was ready to merge a while back :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #723