-
Notifications
You must be signed in to change notification settings - Fork 10
Decide appropriate hash function(s) for NMT internal / blob hashes #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
avail uses blake2-256 it seems. |
Rollkit doesn't use inclusion proofs. It solely relies on the connected DA node. It's not clear atm how they are going to implement bridging. I was not able to find any mention of inclusion proofs in OP-Stack, although I did not look extremely thoroughly. It sounds in line with the folklore that OP doesn't have fraud proofs. I thought I would have more luck with looking at ethereum-optimism/optimism@develop...celestiaorg:optimism:celestia-develop (last commit is 6ce4e61713b6d588f23f06c08af874f78c13a570) so that I would see the integration of sha256 based proofs of celestia, but no, there are no membership proofs used either. I donno. I feel like given that celestia and avail uses sha256, it's already a good place to start. |
merge conflict I wonder how much more efficient sha256 is in risc0 vs blake2-256. couldn't blake2 also be optimized? |
https://risc0.github.io/ghpages/dev/benchmarks/index.html
I don't have a good insight, but it feels like it should be. Totally depends on the will of risc0 though. |
Today on the sync call we decided to go with sha256 for now. Specifically, we may launch on kusama with the sha256 NMT trie. However, we will probably reserve the right to break the compatibility with official launch on polkadot. |
Either choose one or a couple hash functions for extra blobs
Consider using a different hash function for blobs vs NMT nodes
Multiple hash functions = multiple trees + extra overheads per blob in the multi-core model
The text was updated successfully, but these errors were encountered: