Cannot find symbol GenericEditorArea.TEMPLATE_TYPE_KEY

[lazear]

Hi,

I'm trying to build (on Windows, using amazon corretto jdk8) the latest version cloned from GitHub - having a couple issues:

Github\datawarrior\src\com\actelion\research\datawarrior\DataWarrior.java:285:60
java: cannot find symbol
  symbol:   variable TEMPLATE_TYPE_KEY
  location: class com.actelion.research.gui.editor.GenericEditorArea
Github\datawarrior\src\com\actelion\research\datawarrior\DataWarrior.java:286:60
java: cannot find symbol
  symbol:   variable TEMPLATE_TYPE_REACTION_QUERIES
  location: class com.actelion.research.gui.editor.GenericEditorArea
Github\datawarrior\src\com\actelion\research\datawarrior\DataWarrior.java:295:38
java: cannot find symbol
  symbol:   method setReactionQueryTemplates(java.lang.String[][])
  location: class com.actelion.research.gui.editor.GenericEditorArea

git blame says this was introduced ~9 days ago - perhaps the openchemlib.jar file has been updated locally for you, but not checked into git? 1d55833

Also getting 3 errors related to the following:

Github\datawarrior\src\com\actelion\research\datawarrior\task\chem\DETaskAdd3DCoordinates.java:759:36
java: non-static method neutralizeChargedMolecule(com.actelion.research.chem.StereoMolecule) cannot be referenced from a static context

Is there a specific git commit I should be trying to build from?

[lazear]

I can build successfully on f83b589

[thsa]

sorry openchemlib.jar was outdated...

…

________________________________ Von: Michael Lazear ***@***.***> Gesendet: Donnerstag, 17. November 2022 23:03 An: thsa/datawarrior ***@***.***> Cc: Subscribed ***@***.***> Betreff: Re: [thsa/datawarrior] Cannot find symbol `GenericEditorArea.TEMPLATE_TYPE_KEY` (Issue #10) I can build successfully on f83b589<https://che01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fthsa%2Fdatawarrior%2Fcommit%2Ff83b589117100bbfb2591fc34d5416c10d3ef5a5&data=05%7C01%7Cthomas.sander%40idorsia.com%7Cc68bf56ae1fb437416d708dac8e7899a%7Cbb9214bf0cb941fdbd55d0c1c3eda110%7C0%7C0%7C638043194010735161%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=eWw%2B21%2B%2FI0Tsob4%2BdhncPndKTMa9Y4VzBeqcCrKupbc%3D&reserved=0> — Reply to this email directly, view it on GitHub<https://che01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fthsa%2Fdatawarrior%2Fissues%2F10%23issuecomment-1319266039&data=05%7C01%7Cthomas.sander%40idorsia.com%7Cc68bf56ae1fb437416d708dac8e7899a%7Cbb9214bf0cb941fdbd55d0c1c3eda110%7C0%7C0%7C638043194010735161%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=fTh74MdhCb0%2FwH1rpY%2F6Wq3YUenqwTWVI9YSnJzkopw%3D&reserved=0>, or unsubscribe<https://che01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACNFEBUSWBSWFPH3HEZATE3WI2TSNANCNFSM6AAAAAASD3DZ74&data=05%7C01%7Cthomas.sander%40idorsia.com%7Cc68bf56ae1fb437416d708dac8e7899a%7Cbb9214bf0cb941fdbd55d0c1c3eda110%7C0%7C0%7C638043194010735161%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=yAjMJvjjx8yivSHLbN%2FxKt%2FOg7TQQbbar58A5B4ZwF0%3D&reserved=0>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

________________________________ The information of this email and in any file transmitted with it is strictly confidential and may be legally privileged. It is intended solely for the addressee. If you are not the intended recipient, any copying, distribution or any other use of this email is prohibited and may be unlawful. In such case, you should please notify the sender immediately and destroy this email. The content of this email is not legally binding unless confirmed by letter. Any views expressed in this message are those of the individual sender, except where the message states otherwise and the sender is authorized to state them to be the views of the sender's company.

[lazear]

Thanks!

I've just added support for AWS Athena as a SQL database provider in our fork: https://github.com/belharra-tx/datawarrior/tree/athena

Unfortunately, this took a couple hours of debugging because the AWS Athena driver comes bundled with log4j v2.12.1 and the opsin.jar library provides v2.18 ... there is a class method present in v2.12 that was deleted in v2.18 (!! - apparently log4j is not using semantic versioning??). I had to build my own version of opsin with log4j v2.12.1 to resolve this issue - seems like this is something Maven could help prevent (I am a total Java neophyte, so not sure if that's how Java deps work)?

I saw a relevant issue on the tracker: #6 - would you like some help with this? I'm wondering if it's possible for you to have github projects with your forks of the libraries you have manually edited. And also if you are interested in getting some kind of CI/CD or release/tag version set up on GitHub?

I think we will be using DataWarrior internally so I can probably dedicate a few hours to helping out with these issues if you are interested!

[mjw99]

@lazear BTW, I have an experimental fork of a mavenised form of datawarrior here; please see the instructions in that fork's readme for compiling.