Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: make Trainer more flexible #1204

Open
MischaPanch opened this issue Aug 14, 2024 · 0 comments
Open

Refactoring: make Trainer more flexible #1204

MischaPanch opened this issue Aug 14, 2024 · 0 comments
Labels
refactoring No change to functionality
Milestone
Release 2.0.0

Comments

@MischaPanch
Copy link
Collaborator

MischaPanch commented Aug 14, 2024 •
edited
Loading

The Trainer currently uses a bunch of functions injected into it and also tracks a bunch of specific variables which is more restrictive than necessary. See e.g. discussion in #1202 (comment)

The situation can likely be improved by switching to something more similar to the Strategy pattern, but this would constitute a rather large breaking change. Might be addressed by release 2.0 or before that
@MischaPanch MischaPanch added the refactoring No change to functionality label Aug 14, 2024
@MischaPanch MischaPanch added this to the Release 2.0.0 milestone Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring No change to functionality
Projects
None yet
Milestone
Release 2.0.0
Development

No branches or pull requests
1 participant
@MischaPanch