Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "add comment" button visibility #1689

Open
ad-on-is opened this issue Feb 7, 2025 · 6 comments
Open

Improve "add comment" button visibility #1689

ad-on-is opened this issue Feb 7, 2025 · 6 comments

Comments

@ad-on-is
Copy link

ad-on-is commented Feb 7, 2025

On mobile, the add comment button is barely noticeable, since it has the same bg color as the background.

Image

@micahmo
Copy link
Member

micahmo commented Feb 7, 2025

This looks decent in light mode, I think because the shadow differentiates the floating button well enough.

Image

But I agree in dark mode, the floating button definitely blends in. How about we use a slightly tinted color, based on the theme?

Before After (Blue Theme) After (Green Theme)
Image Image Image

I'm just messing around here, so we can tweak things. How does it look?

@ad-on-is
Copy link
Author

ad-on-is commented Feb 7, 2025

If you're asking me, I like it.

can you try the primary theme color, for consistency with the create post button?

@micahmo
Copy link
Member

micahmo commented Feb 7, 2025

Sure! I also didn't want the floating button in the comments to be too abrasive, especially if people are used to it blending in. But you make a good point that it would be more consistent with the main feed FAB. What do you think?

Image Image

@ad-on-is
Copy link
Author

ad-on-is commented Feb 7, 2025

I like the primary color better, since it feels somehow more noticeable

@micahmo
Copy link
Member

micahmo commented Feb 7, 2025

Cool, I'll proceed with that change! It might take a bit because there are some edge cases to handle (namely, the experimental post page...). Thanks for the feedback!

@ad-on-is
Copy link
Author

ad-on-is commented Feb 7, 2025

All good, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants