Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should addFileExtension be required? #2

Open
kirill-chirkov-at-clouty opened this issue Jul 23, 2019 · 3 comments
Open

Should addFileExtension be required? #2

kirill-chirkov-at-clouty opened this issue Jul 23, 2019 · 3 comments

Comments

@kirill-chirkov-at-clouty

Thanks for the awesome template, really great job. There's a humble question/bug though:

validation_rule
This is not required for initialization, e.g. official inject script example:

ym(XXXXXXXX, "init", {
        clickmap:true,
        trackLinks:true,
        accurateTrackBounce:true,
        webvisor:true,
        trackHash:true
   });

there's nothing specified about addFileExtension, so I wonder whether this field should be required and if so, what are the reasons for that.

@thyngster
Copy link
Owner

Please check that trackLinks must be true to have this having any effect. So as I understand this feature is trackLinks is equal to true, then you can specify which extension files to track.

I'm not much used to this feature, will try to review how it really works.

@thyngster
Copy link
Owner

But now that I check it maybe it's better to convert this into a explicit method on the tag, instead of hacing it as I did. Have some updates for the template on local, will cover this as well.

Thanks for the report!

@kirill-chirkov-at-clouty
Copy link
Author

For now I just disabled validation rule for this field. Thank you for looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants