Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation changes #111

Open
dilbernd opened this issue Dec 22, 2024 · 0 comments
Open

Documentation changes #111

dilbernd opened this issue Dec 22, 2024 · 0 comments

Comments

@dilbernd
Copy link

Hi, first of all many thanks for the stellar work; the images scratch a huge itch. Upgrading docker envs with Postgres 13 which has less than a year now were unexpectedly breezy.

I’d just advise some changes to the readme on docker hub.

  1. The upgrade potentially creates hints/script files e.g. for extension upgrades which get lost with --rm.

I’d remove the --rm from the recommended run and note that the corresponding files are available in the "upper dir" of the container after run, or even advise also mounting the upgrader work dir in.

  1. For sufficient paranoia, --network none might instead be advisable since the upgrade does not need connectivity and it removes exfil concerns for closed envs.

  2. pg_hba for docker envs, which will likely be a good part of the user base, needs some adaptation after upgrade.

  3. potentially also the postgresql.conf? How do you handle that for your upgrades?

If you’d like to save time on these docs changes, I’d be happy to make the changes if you’re willing to accept pull reqs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant