Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flight Overhead: Use schema.Location and provide better descriptions for default values in schema fields #1781

Merged
merged 7 commits into from
Sep 5, 2023

Conversation

kylebolstad
Copy link
Contributor

@kylebolstad kylebolstad commented Aug 29, 2023

Description

To help new users who are installing the app for the first time, provide better descriptions and default values in the schema fields.

Copilot

🤖 Generated by Copilot at c07e55a

Summary

📍🐾🗑️

Updated the flightoverhead app to require a location and a flight data provider, and removed unused features. This improves the app's usability and reliability.

To improve the app's usability
The parameters were made reliable
The location and provider
Were required to decide for
The features that were not viable

Walkthrough

  • Simplify and improve user interface and documentation of app parameters (link, link, link, link)
  • Validate and use device's location and timezone instead of hard-coded or user-provided values (link, link)
  • Remove unused or redundant code and variables (link, link)

@tidbyt
Copy link

tidbyt bot commented Aug 29, 2023

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
App Dir All files are in a single app directory
🟡 Modules Usage of animation.star requires review
Original Author The original author matches the PR author

Previews

apps/flightoverhead/flight_overhead.star:

@kylebolstad kylebolstad changed the title Flight Overhead: provide better descriptions and default values in schema fields Flight Overhead: Use schema.location and provide better descriptions for default values in schema fields Aug 30, 2023
@kylebolstad kylebolstad changed the title Flight Overhead: Use schema.location and provide better descriptions for default values in schema fields Flight Overhead: Use schema.Location and provide better descriptions for default values in schema fields Aug 30, 2023
@matslina matslina merged commit 60fc8f8 into tidbyt:main Sep 5, 2023
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants