Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: ATP Tennis & WTA Tennis #1784

Closed
wants to merge 3 commits into from
Closed

Conversation

M0ntyP
Copy link
Contributor

@M0ntyP M0ntyP commented Aug 29, 2023

Description

Updated scheduled match logic to only show if both players are listed, prevents blanks
Updated checking for walkovers

Copilot

🤖 Generated by Copilot at 9c90174

Summary

🎾🐛🧹

This pull request fixes a bug in the atp_tennis and wta_tennis apps that caused blank matches to appear on the display. It also improves the code readability and adds version comments to both apps.

Sing, O Muse, of the skillful programmers who fixed the tennis apps
That show the glorious contests of the swift-footed athletes
They filtered out the matches that lacked both noble opponents
And simplified the code that displays the splendid schedule

Walkthrough

  • Add version number and update comment to atp_tennis.star and wta_tennis.star files (link, link)
  • Filter out scheduled matches without both players in getScheduledMatches function for both ATP and WTA apps (link, link)
  • Simplify displayScheduledMatches function for both ATP and WTA apps by removing redundant checks for "athlete" key (link, link)

Updated scheduled matches to only show if both players are listed, prevents blanks
@tidbyt
Copy link

tidbyt bot commented Aug 29, 2023

⚠️ The automated review process is experimental and likely has bugs. Please bear with us as we iron out the kinks and enable you to ship changes at high velocity 🚀

Next Steps

Hello! Thank you so much for your change 🤜 🤛 . There are a few things you need to do:

  • Sign the CLA if you haven't already
  • Ensure your build is green! Any problem will display a proposed solution to try out
  • Get a review, either by Tidbyt Bot or by a Tidbyt engineer

Manual Review Required

Hang tight! A Tidbyt engineer will be by shortly to review your change. Here is what they will be looking for:

Test Details
🟡 App Dir Touches files in multiple directories
🟡 Modules Multiple .star files: apps/atptennis/atp_tennis.star, apps/wtatennis/wta_tennis.star
🟡 Original Author The original author (matslina) does not match the PR author (M0ntyP)

Previews

apps/atptennis/atp_tennis.star:

apps/wtatennis/wta_tennis.star:

@M0ntyP M0ntyP closed this Aug 31, 2023
@tidbyt tidbyt locked as resolved and limited conversation to collaborators Sep 3, 2023
@M0ntyP M0ntyP deleted the Tennis-Apps-v1.9 branch January 13, 2024 23:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant