Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discrete and continuous color scales have different logic in using options values #4466

Closed
clauswilke opened this issue May 5, 2021 · 1 comment

Comments

@clauswilke
Copy link
Member

See discussion in #4456: The question is whether settings for fill should be applied to colour and vice versa or not. Currently discrete scales do so, continuous scales do not.

Related: #4149

@teunbrand
Copy link
Collaborator

In #5946 we grab default palettes from the theme. The type option still exists for backward compatibility reasons, but this is no longer the preferred approach to setting default palettes. As such, the inconcistency described in this issue becomes just a historical flaw that I probably doesn't require a fix. For this reason, I'll consider this issue fixed by #5946.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants