Skip to content

fix wrong parameters due to partial matching #6410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Yunuuuu
Copy link
Contributor

@Yunuuuu Yunuuuu commented Apr 9, 2025

fix #6408

@Yunuuuu
Copy link
Contributor Author

Yunuuuu commented Apr 9, 2025

It seems difficult to fix all of these by simply initilizing all required parameters, as some Geom and Stat classes rely on this behavior to dispatch default arguments. This PR wrap the params into a new class to avoid partial matching

@teunbrand
Copy link
Collaborator

Thanks for the PR, but I don't think making a new class just to disable partial matching is the right solution for this problem. I'd rather just fix instances of partially matched parameters and/or have a unit test that scans all Geom/Stat class parameters for potential issues (to a similar tune of tests/testthat/test-function-args.R).

@Yunuuuu
Copy link
Contributor Author

Yunuuuu commented Apr 14, 2025

Thanks! I'm totally fine with whichever method works best—as long as the issue gets resolved, that’s what matters most.

@teunbrand
Copy link
Collaborator

I'm closing this PR in favour of #6428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong parameters due to partial matching
2 participants