Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

range() on yearweek objects drops week_start #300

Closed
jrauser opened this issue Jul 27, 2023 · 1 comment
Closed

range() on yearweek objects drops week_start #300

jrauser opened this issue Jul 27, 2023 · 1 comment

Comments

@jrauser
Copy link

jrauser commented Jul 27, 2023

I think a range() that operates specifically on yearweek objects is required.

library(tsibble)
#> 
#> Attaching package: 'tsibble'
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, union
wk <- make_yearweek(2023, 21:50, week_start=7)
wk[1]
#> <yearweek[1]>
#> [1] "2023 W21"
#> # Week starts on: Sunday
range(wk)
#> <yearweek[2]>
#> [1] "2023 W20" "2023 W49"
#> # Week starts on: Monday

Related to: tidyverts/fable#397

@earowang
Copy link
Member

fixed in #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants