diff --git a/common_sensor_launch/launch/hesai_OT128.launch.xml b/common_sensor_launch/launch/hesai_OT128.launch.xml index d381b2ae..5ebd3bf9 100644 --- a/common_sensor_launch/launch/hesai_OT128.launch.xml +++ b/common_sensor_launch/launch/hesai_OT128.launch.xml @@ -2,7 +2,6 @@ - diff --git a/common_sensor_launch/launch/hesai_XT32.launch.xml b/common_sensor_launch/launch/hesai_XT32.launch.xml index c35ab1ca..f12affbe 100644 --- a/common_sensor_launch/launch/hesai_XT32.launch.xml +++ b/common_sensor_launch/launch/hesai_XT32.launch.xml @@ -21,7 +21,7 @@ - + diff --git a/common_sensor_launch/launch/nebula_node_container.launch.py b/common_sensor_launch/launch/nebula_node_container.launch.py index 6ba7f2b2..e1c95c8f 100644 --- a/common_sensor_launch/launch/nebula_node_container.launch.py +++ b/common_sensor_launch/launch/nebula_node_container.launch.py @@ -126,9 +126,11 @@ def create_parameter_dict(*args): ) ) - # There is an issue where hw_monitor crashes due to data race, + # There is an issue where hw_monitor crashes due to data race, # so the monitor will now only be launched when explicitly specified with a launch command. - if LaunchConfiguration("launch_hw_monitor").perform(context): + launch_hw_monitor: bool = context.perform_substitution(LaunchConfiguration("launch_hw_monitor")) + launch_driver: bool = context.perform_substitution(LaunchConfiguration("launch_driver")) + if launch_hw_monitor and launch_driver: nodes.append( ComposableNode( package="nebula_ros", @@ -155,7 +157,9 @@ def create_parameter_dict(*args): ), }, ], - extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}], + extra_arguments=[ + {"use_intra_process_comms": LaunchConfiguration("use_intra_process")} + ], ) ) @@ -339,7 +343,8 @@ def add_launch_arg(name: str, default_value=None, description=None): add_launch_arg( "launch_hw_monitor", "False", - "do launch hardware monitor. Due to an issue where hw_monitor crashes due to data conflicts, the monitor in launched only when explicitly specified") + "do launch hardware monitor. Due to an issue where hw_monitor crashes due to data conflicts, the monitor in launched only when explicitly specified", + ) add_launch_arg("setup_sensor", "True", "configure sensor") add_launch_arg("retry_hw", "false", "retry hw") add_launch_arg("sensor_ip", "192.168.1.201", "device ip address")