From 6ce6e7bf38e6e493b95619cd30878ef255482a7d Mon Sep 17 00:00:00 2001 From: Sho Iwasawa Date: Sun, 27 Oct 2024 23:29:01 -0700 Subject: [PATCH 1/2] remove duplicate code Signed-off-by: Sho Iwasawa --- .../launch/nebula_node_container.launch.py | 30 ------------------- 1 file changed, 30 deletions(-) diff --git a/common_sensor_launch/launch/nebula_node_container.launch.py b/common_sensor_launch/launch/nebula_node_container.launch.py index 66336263..68736b64 100644 --- a/common_sensor_launch/launch/nebula_node_container.launch.py +++ b/common_sensor_launch/launch/nebula_node_container.launch.py @@ -129,36 +129,6 @@ def create_parameter_dict(*args): ) ) - nodes.append( - ComposableNode( - package="nebula_ros", - plugin=sensor_make + "HwMonitorRosWrapper", - name=sensor_make.lower() + "_hw_monitor_ros_wrapper_node", - parameters=[ - { - "sensor_model": sensor_model, - **create_parameter_dict( - "return_mode", - "frame_id", - "scan_phase", - "sensor_ip", - "host_ip", - "data_port", - "gnss_port", - "packet_mtu_size", - "rotation_speed", - "cloud_min_angle", - "cloud_max_angle", - "diag_span", - "dual_return_distance_threshold", - "delay_monitor_ms", - ), - }, - ], - extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}], - ) - ) - # There is an issue where hw_monitor crashes due to data race, # so the monitor will now only be launched when explicitly specified with a launch command. launch_hw_monitor: bool = IfCondition(LaunchConfiguration("launch_hw_monitor")).evaluate( From cf4339c00484e633311799a672505489e947cbe3 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 29 Oct 2024 01:26:23 +0000 Subject: [PATCH 2/2] ci(pre-commit): autofix --- common_sensor_launch/launch/nebula_node_container.launch.py | 1 - 1 file changed, 1 deletion(-) diff --git a/common_sensor_launch/launch/nebula_node_container.launch.py b/common_sensor_launch/launch/nebula_node_container.launch.py index 0f4fa0d7..68736b64 100644 --- a/common_sensor_launch/launch/nebula_node_container.launch.py +++ b/common_sensor_launch/launch/nebula_node_container.launch.py @@ -129,7 +129,6 @@ def create_parameter_dict(*args): ) ) - # There is an issue where hw_monitor crashes due to data race, # so the monitor will now only be launched when explicitly specified with a launch command. launch_hw_monitor: bool = IfCondition(LaunchConfiguration("launch_hw_monitor")).evaluate(