Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add note for api name #47

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

isamu-takagi
Copy link
Collaborator

@isamu-takagi isamu-takagi commented Nov 28, 2024

Description

APIの別名に関する注釈を追加しました。

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@isamu-takagi isamu-takagi self-assigned this Nov 28, 2024
kentdotn
kentdotn previously approved these changes Nov 28, 2024
Copy link

@kentdotn kentdotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。LGTMです。

Signed-off-by: Takagi, Isamu <[email protected]>
Signed-off-by: Takagi, Isamu <[email protected]>
Copy link

@kentdotn kentdotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!!

@isamu-takagi isamu-takagi merged commit 5e25aea into tier4:tier4/main Nov 28, 2024
7 checks passed
@isamu-takagi isamu-takagi deleted the feat/note-for-api-name branch November 28, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants