Skip to content

Commit

Permalink
fix(avoidance): add missing parameter declaration (autowarefoundation…
Browse files Browse the repository at this point in the history
…#6908)

Signed-off-by: satoshi-ota <[email protected]>
  • Loading branch information
satoshi-ota committed May 1, 2024
1 parent 939877f commit 2032dcf
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ AvoidanceParameters getParameter(rclcpp::Node * node)
getOrDeclareParameter<double>(*node, ns + "min_road_shoulder_width");
}

{
const std::string ns = "avoidance.target_filtering.merging_vehicle.";
p.th_overhang_distance = getOrDeclareParameter<double>(*node, ns + "th_overhang_distance");
}

{
const std::string ns = "avoidance.target_filtering.avoidance_for_ambiguous_vehicle.";
p.enable_avoidance_for_ambiguous_vehicle = getOrDeclareParameter<bool>(*node, ns + "enable");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -686,7 +686,7 @@
"properties": {
"th_overhang_distance": {
"type": "number",
"description": "Distance threshold between overhang point and ego lane's centerline. If the nearest overhang point of merging/deviating vehicle is less than this param, the module never avoid it. (Basically, the ego stops behind of it.)",
"description": "Distance threshold to ignore merging/deviating vehicle to/from ego driving lane. The distance represents how the object polygon overlaps ego lane, and it's calculated from polygon overhang point and lane centerline. If the distance is more than this param, the module never avoid the object. (Basically, the ego stops behind of it.)",
"default": 0.5
}
},
Expand Down
5 changes: 5 additions & 0 deletions planning/behavior_path_avoidance_module/src/manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,11 @@ void AvoidanceModuleManager::updateModuleParams(const std::vector<rclcpp::Parame
updateParam<double>(parameters, ns + "backward_distance", p->object_check_backward_distance);
}

{
const std::string ns = "avoidance.target_filtering.merging_vehicle.";
updateParam<double>(parameters, ns + "th_overhang_distance", p->th_overhang_distance);
}

{
const std::string ns = "avoidance.avoidance.lateral.avoidance_for_ambiguous_vehicle.";
updateParam<bool>(parameters, ns + "enable", p->enable_avoidance_for_ambiguous_vehicle);
Expand Down

0 comments on commit 2032dcf

Please sign in to comment.