Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lane_departure_checker): empty lanelet polygon (#6588) #1188

Conversation

danielsanchezaran
Copy link

Universe PR: autowarefoundation#6588
Ticket: https://tier4.atlassian.net/browse/RT1-5672

Fixes an issue were the start planner's output path is incomplete and the ego vehicle cannot engage.

  • fix union sometimes returning empty polygon

  • fix union of polygons

  • fix back launcher


Description

Related links

autowarefoundation#6588

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…n#6588)

* fix union sometimes returning empty polygon

Signed-off-by: Daniel Sanchez <[email protected]>

* fix union of polygons

Signed-off-by: Daniel Sanchez <[email protected]>

* fix back launcher

Signed-off-by: Daniel Sanchez <[email protected]>

---------

Signed-off-by: Daniel Sanchez <[email protected]>
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit 33c148f into beta/v0.20.1.4 Mar 12, 2024
14 of 15 checks passed
@shmpwk shmpwk deleted the beta/v0.20.1.4-lane-departure-checker-lanelet-polygon-fix branch March 12, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants