diff --git a/awsim_sensor_kit_launch/launch/lidar.launch.xml b/awsim_sensor_kit_launch/launch/lidar.launch.xml index 58abe01..79add12 100644 --- a/awsim_sensor_kit_launch/launch/lidar.launch.xml +++ b/awsim_sensor_kit_launch/launch/lidar.launch.xml @@ -1,7 +1,6 @@ - @@ -13,6 +12,7 @@ + @@ -21,6 +21,7 @@ + @@ -29,6 +30,7 @@ + @@ -36,7 +38,6 @@ - diff --git a/awsim_sensor_kit_launch/launch/pointcloud_preprocessor.launch.py b/awsim_sensor_kit_launch/launch/pointcloud_preprocessor.launch.py index 456dc27..a230ce0 100644 --- a/awsim_sensor_kit_launch/launch/pointcloud_preprocessor.launch.py +++ b/awsim_sensor_kit_launch/launch/pointcloud_preprocessor.launch.py @@ -51,31 +51,14 @@ def launch_setup(context, *args, **kwargs): extra_arguments=[{"use_intra_process_comms": LaunchConfiguration("use_intra_process")}], ) - # set container to run all required components in the same process - container = ComposableNodeContainer( - name=LaunchConfiguration("individual_container_name"), - namespace="", - package="rclcpp_components", - executable=LaunchConfiguration("container_executable"), - composable_node_descriptions=[], - condition=UnlessCondition(LaunchConfiguration("use_pointcloud_container")), - output="screen", - ) - - target_container = ( - container - if UnlessCondition(LaunchConfiguration("use_pointcloud_container")).evaluate(context) - else LaunchConfiguration("pointcloud_container_name") - ) - # load concat or passthrough filter concat_loader = LoadComposableNodes( composable_node_descriptions=[concat_component], - target_container=target_container, + target_container=LaunchConfiguration("pointcloud_container_name"), condition=IfCondition(LaunchConfiguration("use_concat_filter")), ) - return [container, concat_loader] + return [concat_loader] def generate_launch_description(): @@ -88,9 +71,7 @@ def add_launch_arg(name: str, default_value=None): add_launch_arg("base_frame", "base_link") add_launch_arg("use_multithread", "False") add_launch_arg("use_intra_process", "False") - add_launch_arg("use_pointcloud_container", "False") add_launch_arg("pointcloud_container_name", "pointcloud_container") - add_launch_arg("individual_container_name", "concatenate_container") set_container_executable = SetLaunchConfiguration( "container_executable", diff --git a/awsim_sensor_kit_launch/launch/sensing.launch.xml b/awsim_sensor_kit_launch/launch/sensing.launch.xml index 7d7a3e8..51eef61 100644 --- a/awsim_sensor_kit_launch/launch/sensing.launch.xml +++ b/awsim_sensor_kit_launch/launch/sensing.launch.xml @@ -2,7 +2,6 @@ - @@ -10,7 +9,6 @@ - diff --git a/common_awsim_sensor_launch/launch/velodyne_lidar.launch.xml b/common_awsim_sensor_launch/launch/velodyne_lidar.launch.xml index 360f7a7..036ff39 100644 --- a/common_awsim_sensor_launch/launch/velodyne_lidar.launch.xml +++ b/common_awsim_sensor_launch/launch/velodyne_lidar.launch.xml @@ -2,11 +2,13 @@ + + diff --git a/common_awsim_sensor_launch/launch/velodyne_node_container.launch.py b/common_awsim_sensor_launch/launch/velodyne_node_container.launch.py index e8e778c..40291ab 100644 --- a/common_awsim_sensor_launch/launch/velodyne_node_container.launch.py +++ b/common_awsim_sensor_launch/launch/velodyne_node_container.launch.py @@ -122,7 +122,7 @@ def create_parameter_dict(*args): # set container to run all required components in the same process container = ComposableNodeContainer( # need unique name, otherwise all processes in same container and the node names then clash - name="velodyne_node_container", + name=LaunchConfiguration("container_name"), namespace="pointcloud_preprocessor", package="rclcpp_components", executable=LaunchConfiguration("container_executable"),