Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common_awsim_sensor_launch): distortion corrector add new param #20

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Oct 10, 2024

Description

PR autowarefoundation/autoware.universe#8380 add a new parameter for distortion correction node, thus common sensor launch also needs to update the parameter

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@vividf
Copy link
Contributor Author

vividf commented Oct 10, 2024

@SakodaShintaro could you review this, thanks!

@SakodaShintaro
Copy link
Contributor

I'm sorry, I don't have the authority to change the reviewer either.

@shmpwk
Could you review this?

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit c72ae1f into tier4:main Oct 10, 2024
5 of 6 checks passed
@vividf vividf self-assigned this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants