Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add launch_pytest to rosinstall argument to fix build errors in … #52

Merged
merged 1 commit into from
May 24, 2024

Conversation

softyanija
Copy link
Contributor

@softyanija softyanija commented Apr 5, 2024

Environment

Ubuntu 18.04
ADLINK RQX-58G (L4T R32.6.1)
R32 (release), REVISION: 6.1, GCID: 27863751, BOARD: t186ref, EABI: aarch64, DATE: Mon Jul 26 19:36:31 UTC 2021

Description

I ran ./setup-dev-env.sh to setting up a new roscube and got the following error.

TASK [ros2 : rosdep install] ***************************************************
fatal: [localhost]: FAILED! => {"changed": true, "cmd": "rosdep install -y --ignore-src --from-paths src --rosdistro humble --skip-keys \"libopencv-dev libopencv-contrib-dev libopencv-imgproc-dev python-opencv python3-opencv\"", "delta": "0:00:13.080717", "end": "2024-03-22 14:16:21.890241", "msg": "non-zero return code", "rc": 1, "start": "2024-03-22 14:16:08.809524", 
"stderr": "ERROR: the following packages/stacks could not have their rosdep keys resolved\nto system dependencies:\ndiagnostic_aggregator: No definition of [launch_pytest] for OS version [bionic]", "stderr_lines": ["ERROR: the following packages/stacks could not have their rosdep keys resolved", "to system dependencies:", "diagnostic_aggregator: No definition of [launch_pytest] for OS version [bionic]"], "stdout": "", "stdout_lines": []}

To fix this, I added launch_pytest to rosinstall argument to fix build errors in ros2.

rosinstall_generator --deps --rosdistro {{ ros_distro }} ros_base launch_xml launch_yaml launch_testing launch_testing_ament_cmake demo_nodes_cpp demo_nodes_py example_interfaces camera_calibration_parsers camera_info_manager cv_bridge vision_opencv vision_msgs image_geometry image_pipeline image_transport compressed_image_transport compressed_depth_image_transport pcl_msgs perception_pcl launch_pytest --exclude rmw_connextdds > /tmp/ros2.{{ ros_distro }}.ros_base.rosinstall

Tests performed

Build was succesful in my environment.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ros2

Note: Confirm the contribution guidelines before submitting a pull request.

Click the Preview tab and select a PR template:

Do NOT send a PR with this description.

@softyanija softyanija marked this pull request as ready for review April 19, 2024 07:44
@manato manato self-assigned this May 24, 2024
Copy link
Collaborator

@manato manato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@manato manato merged commit df4b3cc into tier4:main May 24, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants