Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add autoware prefix to tensorrt_yolox #13

Conversation

ktro2828
Copy link

PR Type

  • Refactor

Related Links

Parent issue:

Description

This PR adds autoware prefix to tensorrt_yolox.
Move from #12 to merge into refactor/autoware-prefix.

Review Procedure

Remarks

This PR must be merge after the above PR has been merged.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Copy link

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but I can not test this.

@ktro2828 ktro2828 merged commit acaee04 into tier4:refactor/autoware-prefix Jul 25, 2024
11 of 16 checks passed
@ktro2828 ktro2828 deleted the refactor/tensorrt_yolox/autoware-prefix branch July 25, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants