Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log-messages): lower log level for a log message from info to debug #6

Merged

Conversation

ahmeddesokyebrahim
Copy link

@ahmeddesokyebrahim ahmeddesokyebrahim commented Jan 13, 2024

Description

This PR is one of group of PRs that aim to fix Autoware logging system to achieve the goal of reducing excessive error and warning logs on Autoware launch.

Fixes autowarefoundation/autoware.universe#5539

Related links

More details in the issue.

Relevant PRS

Tests performed

  • Planning Simulation
    • Run Autoware planning simulator and you can see no more excessive and recurring error, warning, and info message when the system running as expected
  • Rosbag Replay Simulation
    • To be addressed in another PR
  • AWSIM
    • To be addressed in another PR - extended goal

Notes for reviewers

Take into consideration relevant PRs.

Interface changes

N.A

Effects on system behavior

  • Improved console output => better developer experience specially for debugging and catching actual problems.
  • Some recurrent info messages are lowered to debug level. So the developer would need to set the logger level of that specific node to see the debug message.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mitsudome-r mitsudome-r merged commit d969ec6 into tier4:tier4/main Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce excessive error and warning logs on Autoware launch
2 participants