Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker workflow improvements #298

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Docker workflow improvements #298

merged 1 commit into from
Feb 24, 2025

Conversation

svenklemm
Copy link
Member

No description provided.

@svenklemm svenklemm force-pushed the docker_debug branch 23 times, most recently from eed2510 to 61805fc Compare February 11, 2025 10:22
@darthmaim
Copy link

Hi @svenklemm,

is this PR supposed to publish a new image tagged as 2.18.1-pg17 to dockerhub with every push? Looking at https://hub.docker.com/r/timescale/timescaledb/tags?name=2.18.1-pg17 I can see that it was pushed only a few minutes ago and is missing the usual architectures, probably causing #299 for me.

@svenklemm svenklemm force-pushed the docker_debug branch 4 times, most recently from 92ca50d to bade666 Compare February 11, 2025 12:22
@svenklemm
Copy link
Member Author

This was not supposed to push to registry, which platform are you on?

@darthmaim
Copy link

darthmaim commented Feb 11, 2025 •
edited
Loading

I'm on arm64, and https://hub.docker.com/r/timescale/timescaledb/tags?name=2.18.1-pg17 only has linux/amd64 at the moment.

Compare this to https://hub.docker.com/r/timescale/timescaledb/tags?name=2.18.0-pg17 which has linux/386, linux/amd64, linux/arm/v6, linux/arm/v7 and linux/arm64

Looking at https://hub.docker.com/r/timescale/timescaledb/tags it looks like these tags were pushed in the last few minutes and all are missing architectures:

latest-pg16
2.18.1-pg16
latest-pg17
2.18.1-pg17
latest-pg16-oss
2.18.1-pg16-oss
latest-pg17-oss
2.18.1-pg17-oss
latest-pg14
2.18.1-pg14
latest-pg15
2.18.1-pg15
latest-pg14-oss
latest-pg15-oss
2.18.1-pg14-oss
2.18.1-pg15-oss

@darthmaim darthmaim mentioned this pull request Feb 11, 2025
Closed
@svenklemm svenklemm force-pushed the docker_debug branch 3 times, most recently from 401b34f to e48a178 Compare February 11, 2025 13:22
@darthmaim
Copy link

While it seems like this PR is no longer publishing images, the above mentioned images are still broken. Could you republish those?

@svenklemm svenklemm force-pushed the docker_debug branch 16 times, most recently from 536dc0a to 77fa999 Compare February 12, 2025 05:18
@svenklemm
Copy link
Member Author

Docker images have been republished

@svenklemm
Docker workflow improvements
f3382be 
- Use prebuilt pgvector on PG17
- set timescaledb version to 2.18.2
- do not push to timescaledb registry unless on main or release branch and no_tag_latest is false
@svenklemm svenklemm changed the title Debug docker Docker workflow improvements Feb 24, 2025
@svenklemm svenklemm merged commit 898966f into main Feb 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenklemm @darthmaim