Fix makeaclitem function creation

timescale · Nov 29, 2023 · 65f6815 · 65f6815
1 parent 3b59a8a
commit 65f6815
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/sql/maintenance_utils.sql b/sql/maintenance_utils.sql
@@ -124,12 +124,12 @@ $$ LANGUAGE plpgsql;
 -- with the extension.
 --
 -- This is intended for internal usage and interface might change.
-CREATE FUNCTION _timescaledb_functions.makeaclitem(regrole, regrole, text, bool)
+CREATE OR REPLACE FUNCTION _timescaledb_functions.makeaclitem(regrole, regrole, text, bool)
 RETURNS AclItem AS '@MODULE_PATHNAME@', 'ts_makeaclitem'
 LANGUAGE C STABLE PARALLEL SAFE STRICT;
 
 -- Repair relation ACL by removing roles that do not exist in pg_authid.
-CREATE PROCEDURE _timescaledb_functions.repair_relation_acls()
+CREATE OR REPLACE PROCEDURE _timescaledb_functions.repair_relation_acls()
 LANGUAGE SQL AS $$
   WITH
     badrels AS (

diff --git a/sql/updates/reverse-dev.sql b/sql/updates/reverse-dev.sql
@@ -1 +1,3 @@
-
+-- Manually drop the following functions / procedures since 'OR REPLACE' is missing in 2.13.0
+DROP PROCEDURE IF EXISTS _timescaledb_functions.repair_relation_acls();
+DROP FUNCTION IF EXISTS _timescaledb_functions.makeaclitem(regrole, regrole, text, bool);