Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PG16 - Adapt to the new RTEPerminfo logic. #6072

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

lkshminarayanan
Copy link
Contributor

@lkshminarayanan lkshminarayanan commented Sep 15, 2023

With the two commits included in this PR, timescaledb can be compiled with PG16.

Disable-check: force-changelog-file
Disable-check: commit-count

@github-actions
Copy link

@mahipv, @konskov: please review this pull request.

Powered by pull-review

@lkshminarayanan lkshminarayanan removed their assignment Sep 15, 2023
@lkshminarayanan
Copy link
Contributor Author

Couple more PG16 patches in https://github.com/lkshminarayanan/timescaledb/commits/pg16-fixes if anyone is interested.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #6072 (3f612f0) into main (d07cb91) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6072      +/-   ##
==========================================
- Coverage   81.53%   81.48%   -0.06%     
==========================================
  Files         246      246              
  Lines       56782    56739      -43     
  Branches    12588    12569      -19     
==========================================
- Hits        46297    46232      -65     
- Misses       8103     8117      +14     
- Partials     2382     2390       +8     
Files Coverage Δ
src/copy.c 90.39% <100.00%> (-0.09%) ⬇️
src/import/ht_hypertable_modify.c 61.35% <ø> (ø)
src/nodes/chunk_dispatch/chunk_insert_state.c 88.11% <ø> (-1.05%) ⬇️
src/planner/expand_hypertable.c 88.58% <100.00%> (-0.15%) ⬇️
src/planner/planner.c 90.53% <100.00%> (+0.02%) ⬆️
tsl/src/continuous_aggs/common.c 90.06% <ø> (ø)
tsl/src/continuous_aggs/create.c 90.16% <ø> (ø)
tsl/src/continuous_aggs/finalize.c 94.40% <100.00%> (ø)
tsl/src/continuous_aggs/options.c 92.68% <ø> (ø)
tsl/src/fdw/modify_exec.c 69.62% <100.00%> (+0.22%) ⬆️
... and 4 more

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

fabriziomello
fabriziomello previously approved these changes Sep 15, 2023
@fabriziomello fabriziomello added the pg16 Issue/PR related to support for PG16 label Sep 15, 2023
@fabriziomello
Copy link
Contributor

Couple more PG16 patches in https://github.com/lkshminarayanan/timescaledb/commits/pg16-fixes if anyone is interested.

Thanks a lot @lkshminarayanan ... we'll take care of it and add you as author

@lkshminarayanan
Copy link
Contributor Author

Couple more PG16 patches in https://github.com/lkshminarayanan/timescaledb/commits/pg16-fixes if anyone is interested.

Thanks a lot @lkshminarayanan ... we'll take care of it and add you as author

Sure! Thank you @fabriziomello.

@fabriziomello fabriziomello force-pushed the pg16-rteperminfo branch 2 times, most recently from 356ccfb to 7b8e361 Compare September 21, 2023 22:28
@fabriziomello fabriziomello dismissed their stale review September 27, 2023 13:34

Requires a bit more work

PG16 moves the permission checking information out of the range table
entries into a new struct - RTEPermissionInfo. This commit updates
timescaledb to use the this new mechanism when compiling with PG16.

postgres/postgres@a61b1f74
postgres/postgres@b803b7d1
postgres/postgres@47bb9db7
@fabriziomello fabriziomello merged commit 642970f into timescale:main Sep 28, 2023
34 checks passed
@fabriziomello
Copy link
Contributor

Merged it and will send a following PR with some fixes on regression tests suite.

@lkshminarayanan lkshminarayanan deleted the pg16-rteperminfo branch January 25, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pg16 Issue/PR related to support for PG16
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants