Fix sanitizer output log directory #6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
added
bug
ci
disable-auto-backport
|
@mkindahl, @konskov: please review this pull request.
|
Codecov Report
@@ Coverage Diff @@
## main #6308 +/- ##
==========================================
- Coverage 65.47% 65.44% -0.03%
==========================================
Files 247 247
Lines 57758 57712 -46
Branches 12855 12836 -19
==========================================
- Hits 37815 37771 -44
+ Misses 18094 18087 -7
- Partials 1849 1854 +5 see 17 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
akuzm
reviewed
Nov 11, 2023
akuzm
approved these changes
Nov 11, 2023
fabriziomello
force-pushed
the
fix_sanitizer_output_log_directory
branch
from
b7cec37 to
b6d626b
Compare
mkindahl
approved these changes
Nov 13, 2023
fabriziomello
force-pushed
the
fix_sanitizer_output_log_directory
branch
from
b6d626b to
4dec65f
Compare
In the sanitizer workflow we're trying to upload sanitizer output
logs from `${{ github.workspace }}/sanitizer` but in the ASAN_OPTIONS,
LSAN_OPTIONS and UBSAN_OPTIONS we were setting output logs to another
place.
Example of workflow that files were not found in the provided path:
https://github.com/timescale/timescaledb/actions/runs/6830847083
fabriziomello
force-pushed
the
fix_sanitizer_output_log_directory
branch
from
4dec65f to
a90a0f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the sanitizer workflow we're trying to upload sanitizer output logs from
${{ github.workspace }}/sanitizerbut in the ASAN_OPTIONS, LSAN_OPTIONS and UBSAN_OPTIONS we were setting output logs to another place.Example of workflow that files were not found in the provided path: https://github.com/timescale/timescaledb/actions/runs/6830847083
Disable-check: force-changelog-file