PG16: Fix multinode deparsing issues #6183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziomello
force-pushed
the
pg16-fix-multinode-deparse-issues
branch
from
c501c66 to
aced296
Compare
Codecov Report
@@ Coverage Diff @@
## main #6183 +/- ##
==========================================
- Coverage 81.45% 81.41% -0.04%
==========================================
Files 246 246
Lines 56978 56938 -40
Branches 12626 12614 -12
==========================================
- Hits 46409 46357 -52
+ Misses 8191 8169 -22
- Partials 2378 2412 +34
... and 44 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fabriziomello
force-pushed
the
pg16-fix-multinode-deparse-issues
branch
3 times, most recently
from
cf70e49 to
1b2c6c0
Compare
|
@erimatnor, @konskov: please review this pull request.
|
fabriziomello
force-pushed
the
pg16-fix-multinode-deparse-issues
branch
from
1b2c6c0 to
34a483d
Compare
erimatnor
approved these changes
Oct 11, 2023
With the changes introduced in PG16 by moving the permission checking information out of the range table entries to a new data struct named `RTEPermissionInfo` we can't use the rte->updatedcols anymore for the target_attrs when deparsing, so we need to build new target_attrs based on the `get_rel_all_updated_cols` and for our multinode implementation we need to get rid the generated always attributes to don't risk to build the parameters in `stmt_params_create` using this column. Postgres FDW also have it own logic to skip generated columns as well. postgres/postgres@a61b1f74
fabriziomello
force-pushed
the
pg16-fix-multinode-deparse-issues
branch
from
34a483d to
df085d7
Compare
svenklemm
requested changes
Oct 11, 2023
Ok, will send another PR blocking usage of distributed hypertables |
|
Closing because we decided to don't support multinode on PG16. This PR #6190 remove the support of multinode on PG16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes introduced in PG16 by moving the permission checking information out of the range table entries to a new data struct named
RTEPermissionInfowe can't use the rte->updatedcols anymore for the target_attrs when deparsing, so we need to build new target_attrs based on theget_rel_all_updated_colsand for our multinode implementation we need to get rid the generated always attributes to don't risk to build the parameters instmt_params_createusing this column. Postgres FDW also have it own logic to skip generated columns as well.Disable-check: force-changelog-file