Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust restore points test for PG 16 #6298

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Adjust restore points test for PG 16 #6298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/cron-tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ name: Additional tests
branches:
- main
- prerelease_test
- trigger/additional_tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this new branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@konskov It is a branch that you can use to trigger this workflow. You can push your local changes into our main repository to trigger this workflow using this branch name.

We have these trigger workflows in other GitHub actions as well (e.g., here and here)


jobs:
config:
runs-on: ubuntu-latest
Expand Down
5 changes: 5 additions & 0 deletions scripts/test_restore_points.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,11 @@ if [ ${PG_VERSION_MAJOR} -lt 13 ]; then
exit 1
fi

if [ ${PG_VERSION_MAJOR} -ge 16 ]; then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check is performed in the shell script and not excluded from the build matrix in the workflow since matrix exclusion would require the exact PG version and needs to be adjusted with every version upgrade.

  exclude:
    - pg: "16.0"

Here, we can perform the test based on the PG major version.

echo "Multi-node is currently not supported on PG >= 16"
exit 0
fi

mkdir -p ${RESULT_DIR}

echo "Running single node tests"
Expand Down
Loading