Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-PR creation scripts #7062

Merged
merged 17 commits into from
Nov 11, 2024

Conversation

pallavisontakke
Copy link
Contributor

@pallavisontakke pallavisontakke commented Jun 25, 2024

For minor and patch releases. Pull Request is created on the version branch.

Issue: https://github.com/timescale/eng-database/issues/613

Disable-check: force-changelog-file
Disable-check: commit-count

@pallavisontakke pallavisontakke requested review from fabriziomello, antekresic and svenklemm and removed request for antekresic and svenklemm June 25, 2024 07:46
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (59f50f2) to head (3a54cf7).
Report is 582 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7062      +/-   ##
==========================================
+ Coverage   80.06%   82.58%   +2.51%     
==========================================
  Files         190      229      +39     
  Lines       37181    42731    +5550     
  Branches     9450    10731    +1281     
==========================================
+ Hits        29770    35290    +5520     
- Misses       2997     3156     +159     
+ Partials     4414     4285     -129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pallavisontakke pallavisontakke force-pushed the patch_release_scripts branch 2 times, most recently from af1c213 to e7ef47c Compare November 5, 2024 07:54
@pallavisontakke pallavisontakke changed the title Add patch release PR creation scripts Add release PR creation scripts Nov 6, 2024
@pallavisontakke pallavisontakke changed the title Add release PR creation scripts Add release Pull Request creation scripts Nov 6, 2024
@pallavisontakke pallavisontakke changed the title Add release Pull Request creation scripts Add release-Pull-Request creation scripts Nov 6, 2024
@pallavisontakke pallavisontakke changed the title Add release-Pull-Request creation scripts Add release-PR creation scripts Nov 6, 2024
Instead of supplying them externally.
Accordingly also edit it in the next script.
From git config, instead of CLI input.
For git user parameters setup.
Concerning issue timescale/eng-database#623

Automate minor release : Release PR (for *.*.x branch) creation.
In a different way.
As naming of these files is not consistent.
a bit more, as per review comment.
variables using sed, in release-automation-scripts
from RELEASE_NOTES_HEADER.md.j2.
As now this section is commented in the above header file itself.
From current CHANGELOG.md , instead of keeping it a fixed number of lines.
To fix the shellcheck style issue:
^-- SC2116 (style): Useless echo? Instead of 'cmd $(echo foo)', just use 'cmd foo'.
To remove 2 instances of this warning from the shellcheck run:

^-- SC2010 (warning): Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.
To not trigger commit hooks.
Commiting ==> Committing
To remove 2 instances of this warning from the shellcheck run:

^-- SC2010 (warning): Don't use ls | grep. Use a glob or a for loop with a condition to allow non-alphanumeric filenames.
To remove this shellcheck warning

^----------^ SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.
@pallavisontakke pallavisontakke enabled auto-merge (squash) November 11, 2024 07:35
@pallavisontakke pallavisontakke merged commit b1aa565 into timescale:main Nov 11, 2024
51 checks passed
@pallavisontakke pallavisontakke deleted the patch_release_scripts branch November 11, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants