Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter name to enable Hypercore TAM #7411

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

mkindahl
Copy link
Contributor

Changing from using the compress_using parameter with a table access method name to use the boolean parameter hypercore_use_access_method instead to avoid having to provide a name when using the table access method for compression.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.56%. Comparing base (59f50f2) to head (623270b).
Report is 581 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7411      +/-   ##
==========================================
+ Coverage   80.06%   82.56%   +2.49%     
==========================================
  Files         190      229      +39     
  Lines       37181    42731    +5550     
  Branches     9450    10731    +1281     
==========================================
+ Hits        29770    35279    +5509     
- Misses       2997     3168     +171     
+ Partials     4414     4284     -130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkindahl mkindahl force-pushed the hypercore-use_access_method branch 5 times, most recently from e1d53bc to 22aa0fa Compare October 31, 2024 07:49
@mkindahl mkindahl marked this pull request as ready for review October 31, 2024 07:52
@mkindahl mkindahl force-pushed the hypercore-use_access_method branch 2 times, most recently from 3faae59 to 0dfefaa Compare October 31, 2024 08:17
Copy link
Contributor

@erimatnor erimatnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question about name of configuration in policy json. Should it be the same as the parameter name in compress_chunk?

tsl/src/bgw_policy/policies_v2.h Outdated Show resolved Hide resolved
tsl/test/expected/hypercore_policy.out Outdated Show resolved Hide resolved
@mkindahl
Copy link
Contributor Author

mkindahl commented Nov 4, 2024

Just one question about name of configuration in policy json. Should it be the same as the parameter name in compress_chunk?

Yes, I think so. All user-facing parameters should be coordinated. Will fix.

@mkindahl mkindahl force-pushed the hypercore-use_access_method branch from 45c1e8b to 159ea80 Compare November 4, 2024 18:05
@mkindahl
Copy link
Contributor Author

mkindahl commented Nov 4, 2024

Just one question about name of configuration in policy json. Should it be the same as the parameter name in compress_chunk?

Yes, I think so. All user-facing parameters should be coordinated. Will fix.

Done.

@mkindahl mkindahl force-pushed the hypercore-use_access_method branch from 159ea80 to 39b2556 Compare November 4, 2024 18:06
@mkindahl mkindahl enabled auto-merge (rebase) November 4, 2024 18:08
@mkindahl mkindahl force-pushed the hypercore-use_access_method branch from 39b2556 to a83c471 Compare November 4, 2024 18:12
Changing from using the `compress_using` parameter with a table access
method name to use the boolean parameter `hypercore_use_access_method`
instead to avoid having to provide a name when using the table access
method for compression.
@mkindahl mkindahl force-pushed the hypercore-use_access_method branch from a83c471 to 623270b Compare November 10, 2024 08:30
@mkindahl mkindahl merged commit e5e9496 into timescale:main Nov 10, 2024
45 checks passed
@mkindahl mkindahl deleted the hypercore-use_access_method branch November 10, 2024 13:33
pallavisontakke added a commit to pallavisontakke/timescaledb that referenced this pull request Nov 20, 2024
This release contains performance improvements and bug fixes since
the 2.17.2 release. We recommend that you upgrade at the next
available opportunity.

**Features**
* timescale#7271 Hypercore table access method
* timescale#7271 Push down ORDER BY in real time continuous aggregate queries
* timescale#7295: Support ALTER TABLE SET ACCESS METHOD on hypertable.
* timescale#7390 Disable custom hashagg planner code
* timescale#7411 Change parameter name to enable Hypercore TAM
* timescale#7412 Add GUC for hypercore_use_access_method default
* timescale#7413: Add GUC for segmentwise recompression.

**Bugfixes**
* timescale#7378 Remove obsolete job referencing policy_job_error_retention
* timescale#7409 Update bgw job table when altering procedure
* timescale#7426 Fix datetime parsing error in chunk constraint creation
* timescale#7432 Verify that heap tuple is valid before using
* timescale#7434 Fixes segfault when internally set the replica identity for a given chunk

**Thanks**
* @bharrisau for reporting the segfault when creating chunks
* @pgloader for reporting an issue an internal background job
pallavisontakke added a commit to pallavisontakke/timescaledb that referenced this pull request Nov 22, 2024
This release contains performance improvements and bug fixes since
the 2.17.2 release. We recommend that you upgrade at the next
available opportunity.

**Features**
* timescale#7271 Hypercore table access method
* timescale#7271 Push down ORDER BY in real time continuous aggregate queries
* timescale#7295: Support ALTER TABLE SET ACCESS METHOD on hypertable.
* timescale#7390 Disable custom hashagg planner code
* timescale#7411 Change parameter name to enable Hypercore TAM
* timescale#7412 Add GUC for hypercore_use_access_method default
* timescale#7413: Add GUC for segmentwise recompression.
* timescale#7455: Support DROP NOT NULL on compressed hypertables

**Bugfixes**
* timescale#7378 Remove obsolete job referencing policy_job_error_retention
* timescale#7409 Update bgw job table when altering procedure
* timescale#7426 Fix datetime parsing error in chunk constraint creation
* timescale#7432 Verify that heap tuple is valid before using
* timescale#7434 Fixes segfault when internally set the replica identity for a given chunk

**Thanks**
* @bharrisau for reporting the segfault when creating chunks
* @pgloader for reporting an issue an internal background job
pallavisontakke added a commit to pallavisontakke/timescaledb that referenced this pull request Dec 13, 2024
This release contains performance improvements and bug fixes since
the 2.17.2 release. We recommend that you upgrade at the next
available opportunity.

**Features**
* timescale#6901 Add hypertable support for transition tables
* timescale#7104 Hypercore table access method
* timescale#7271 Push down ORDER BY in real time continuous aggregate queries
* timescale#7295: Support ALTER TABLE SET ACCESS METHOD on hypertable.
* timescale#7390 Disable custom hashagg planner code
* timescale#7411 Change parameter name to enable Hypercore TAM
* timescale#7412 Add GUC for hypercore_use_access_method default
* timescale#7413: Add GUC for segmentwise recompression.
* timescale#7443 Add Hypercore function and view aliases
* timescale#7455: Support DROP NOT NULL on compressed hypertables
* timescale#7486 Prevent building against postgres versions with broken ABI

**Bugfixes**
* timescale#7378 Remove obsolete job referencing policy_job_error_retention
* timescale#7409 Update bgw job table when altering procedure
* timescale#7410 "aggregated compressed column not found" error on aggregation query.
* timescale#7426 Fix datetime parsing error in chunk constraint creation
* timescale#7432 Verify that heap tuple is valid before using
* timescale#7434 Fixes segfault when internally set the replica identity for a given chunk
* timescale#7488 Emit error for transition table trigger on chunks
* timescale#7514 Fix error: invalid child of chunk append

**Thanks**
* @bharrisau for reporting the segfault when creating chunks
* @pgloader for reporting an issue an internal background job
* @uasiddiqi for reporting the "aggregated compressed column not found" error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants