Fix flaky append regression test #7512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erimatnor, @akuzm: please review this pull request.
|
fabriziomello
force-pushed
the
fix_flaky_append
branch
from
b9fdad7 to
2b0847b
Compare
mkindahl
approved these changes
Dec 3, 2024
|
Shouldn't this be fixed by vacuum as well? IIRC we had a similar problem for transparent decompression test |
fabriziomello
force-pushed
the
fix_flaky_append
branch
2 times, most recently
from
bd9401a to
ca7c4d0
Compare
I've sent another commit executing a manual VACUUM and it changed a lot the output: ca7c4d0 At least all the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7512 +/- ##
==========================================
+ Coverage 80.06% 82.18% +2.11%
==========================================
Files 190 230 +40
Lines 37181 43191 +6010
Branches 9450 10869 +1419
==========================================
+ Hits 29770 35495 +5725
- Misses 2997 3371 +374
+ Partials 4414 4325 -89 ☔ View full report in Codecov by Sentry. |
akuzm
approved these changes
Dec 3, 2024
Fixed it by manually running `VACUUM ANALYZE` in all involved hypertables to avoid flaky output tests.
fabriziomello
force-pushed
the
fix_flaky_append
branch
from
ca7c4d0 to
dc4cde3
Compare
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 5, 2024
In timescale#7512 we added manual `VACUUM` in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're replacing the output `Heap Fetches: [0-9]` for `Heap Fetches: 0` to make have a more predictable output test.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 5, 2024
In timescale#7512 we added manual `VACUUM` in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're replacing the output `Heap Fetches: [0-9]` for `Heap Fetches: 0` to make have a more predictable output test.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 5, 2024
In timescale#7512 we added manual `VACUUM` in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're replacing the output `Heap Fetches: [0-9]` for `Heap Fetches: 0` to make have a more predictable output test.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Dec 6, 2024
In timescale#7512 we added manual `VACUUM` in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're replacing the output `Heap Fetches: [0-9]` for `Heap Fetches: 0` to make have a more predictable output test.
fabriziomello
added a commit
that referenced
this pull request
Dec 6, 2024
In #7512 we added manual `VACUUM` in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're replacing the output `Heap Fetches: [0-9]` for `Heap Fetches: 0` to make have a more predictable output test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed it by manually running
VACUUM ANALYZEin all involved hypertables to avoid flaky output tests.https://github.com/timescale/timescaledb/actions/runs/12128976291/job/33819502944?pr=7505#step:17:23
Disable-check: force-changelog-file