Fix flaky append regression test take 2 #7522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mkindahl, @akuzm: please review this pull request.
|
fabriziomello
force-pushed
the
fix_flaky_append_take2
branch
from
adb3288 to
0cf4e41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7522 +/- ##
==========================================
+ Coverage 80.06% 82.19% +2.12%
==========================================
Files 190 230 +40
Lines 37181 43191 +6010
Branches 9450 10869 +1419
==========================================
+ Hits 29770 35501 +5731
- Misses 2997 3367 +370
+ Partials 4414 4323 -91 ☔ View full report in Codecov by Sentry. |
fabriziomello
force-pushed
the
fix_flaky_append_take2
branch
from
0cf4e41 to
f06b0a1
Compare
mkindahl
approved these changes
Dec 6, 2024
akuzm
approved these changes
Dec 6, 2024
In timescale#7512 we added manual `VACUUM` in all involved relations to avoid flaky output tests. But looks like it is not working very well specially on Windows builds, so now we're replacing the output `Heap Fetches: [0-9]` for `Heap Fetches: 0` to make have a more predictable output test.
fabriziomello
force-pushed
the
fix_flaky_append_take2
branch
from
f06b0a1 to
2310c83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7512 we added manual
VACUUMin all involved relations to avoid flaky output tests.But looks like it is not working very well specially on Windows builds, so now we're replacing the output
Heap Fetches: [0-9]forHeap Fetches: 0to make have a more predictable output test.https://github.com/timescale/timescaledb/actions/runs/12166253875/job/33932077535?pr=7517#step:17:23
Disable-check: force-changelog-file
Disable-check: approval-count