-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow CI nightly to fail so badge is green #769
Conversation
The issue is that this failure is going to be on all Julia versions starting with 1.10, so making an exception for nightly soon won't help anything. We just have to fix the test failures. |
but this would be useful for future future? I think it's a general idea to not show red CI badge for Nightly |
Fair enough! |
Hmm, the badge is still red even though only nightly is failing. |
I wonder if this is correct https://github.com/timholy/Revise.jl/blob/9f7bd4ea3d7b2c3bd37e64130abb718aba2a8072/README.md?plain=1#L3C49-L3C49 |
If I try updating it with
(the text supplied by the "Create Status Badge" option, it still shows red. |
ah, we need this line https://github.com/JuliaHEP/UnROOT.jl/blob/77b75d8f8a7d5a6a2b8c408efbcac2c00817e798/.github/workflows/ci.yml#L14C1-L14C51 the I don't know if we can just replace |
Suggestion from #769 (comment)
Suggestion from #769 (comment)
There are two ways of doing this, another possibility is to have a separate
ci_nightly.yml
, let me know if maintainers prefer that route.