Reduced reassignment to global consts #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a single top-level expression contains both `const` definitions and methods that use those consts, the `add_named_dependencies!` step of `lines_required!` can induce a dependency on the statement assigning to the `const`. This is problematic when your only goal is to parse signatures, as it can trigger overwriting of `consts` that may be needed. Fixes #789
|
...and we're green on all except Julia nightly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a single top-level expression contains both
constdefinitions and methods that use those consts, theadd_named_dependencies!step oflines_required!can induce a dependency on the statement assigning to theconst. This is problematic when your only goal is to parse signatures, as it can trigger overwriting ofconststhat may be needed.Fixes #789