-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement an interface for Distributed-like libraries #871
Conversation
a0bc479
to
6d879e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm strongly supportive of anything that reduces dependency on Distributed, especially if the replacements are less vulnerable to invalidations. The overall design of this PR seems OK.
Mostly so that we can use package extensions.
This moves support for Distributed into a package extension and adds an interface for other distributed worker libraries to use to support Revise for their workers.
b468b35
to
5955e0e
Compare
Thanks! Coming out momentarily in Revise 3.7.0. |
How will this work? Right now, I basically do
with
and now if I update Does this workflow need to be changed? |
No, the behaviour should be identical to previous versions. The only change in the PR is to make loading Distributed optional and allow support for other libraries to hook into Revise for their workers. |
@affans , Distributed badly needs re-engineering. This should make it easier to update or replace it. |
This moves support for Distributed into a package extension and adds an interface for other distributed worker libraries (i.e. DistributedNext.jl) to use to support Revise for their workers. Admittedly the interface is quite... clunky... so I'm open to other ideas. This also required bumping the minimum Julia version to 1.9 to use package extensions.
As a bonus the load times are slightly improved: