-
Notifications
You must be signed in to change notification settings - Fork 31
/
Copy pathCONTRIBUTING.html
232 lines (185 loc) · 11.4 KB
/
CONTRIBUTING.html
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
<!-- Generated by pkgdown: do not edit by hand -->
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>NA • DemoTools</title>
<!-- favicons -->
<link rel="icon" type="image/png" sizes="16x16" href="favicon-16x16.png">
<link rel="icon" type="image/png" sizes="32x32" href="favicon-32x32.png">
<link rel="apple-touch-icon" type="image/png" sizes="180x180" href="apple-touch-icon.png" />
<link rel="apple-touch-icon" type="image/png" sizes="120x120" href="apple-touch-icon-120x120.png" />
<link rel="apple-touch-icon" type="image/png" sizes="76x76" href="apple-touch-icon-76x76.png" />
<link rel="apple-touch-icon" type="image/png" sizes="60x60" href="apple-touch-icon-60x60.png" />
<!-- jquery -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js" integrity="sha256-FgpCb/KJQlLNfOu91ta32o/NMZxltwRo8QtmkMRdAu8=" crossorigin="anonymous"></script>
<!-- Bootstrap -->
<link href="https://cdnjs.cloudflare.com/ajax/libs/bootswatch/3.3.7/yeti/bootstrap.min.css" rel="stylesheet" crossorigin="anonymous" />
<script src="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.7/js/bootstrap.min.js" integrity="sha256-U5ZEeKfGNOja007MMD3YBI0A3OSZOQbeG6z2f2Y0hu8=" crossorigin="anonymous"></script>
<!-- Font Awesome icons -->
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.7.1/css/all.min.css" integrity="sha256-nAmazAk6vS34Xqo0BSrTb+abbtFlgsFK7NKSi6o7Y78=" crossorigin="anonymous" />
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.7.1/css/v4-shims.min.css" integrity="sha256-6qHlizsOWFskGlwVOKuns+D1nB6ssZrHQrNj1wGplHc=" crossorigin="anonymous" />
<!-- clipboard.js -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/clipboard.js/2.0.4/clipboard.min.js" integrity="sha256-FiZwavyI2V6+EXO1U+xzLG3IKldpiTFf3153ea9zikQ=" crossorigin="anonymous"></script>
<!-- headroom.js -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/headroom/0.9.4/headroom.min.js" integrity="sha256-DJFC1kqIhelURkuza0AvYal5RxMtpzLjFhsnVIeuk+U=" crossorigin="anonymous"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/headroom/0.9.4/jQuery.headroom.min.js" integrity="sha256-ZX/yNShbjqsohH1k95liqY9Gd8uOiE1S4vZc+9KQ1K4=" crossorigin="anonymous"></script>
<!-- pkgdown -->
<link href="pkgdown.css" rel="stylesheet">
<script src="pkgdown.js"></script>
<meta property="og:title" content="NA" />
<meta property="og:image" content="https://timriffe.github.io/DemoTools/logo.png" />
<meta name="twitter:card" content="summary" />
<!-- mathjax -->
<script src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.5/MathJax.js" integrity="sha256-nvJJv9wWKEm88qvoQl9ekL2J+k/RWIsaSScxxlsrv8k=" crossorigin="anonymous"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/mathjax/2.7.5/config/TeX-AMS-MML_HTMLorMML.js" integrity="sha256-84DKXVJXs0/F8OTMzX4UR909+jtl4G7SPypPavF+GfA=" crossorigin="anonymous"></script>
<!--[if lt IE 9]>
<script src="https://oss.maxcdn.com/html5shiv/3.7.3/html5shiv.min.js"></script>
<script src="https://oss.maxcdn.com/respond/1.4.2/respond.min.js"></script>
<![endif]-->
</head>
<body>
<div class="container template-title-body">
<header>
<div class="navbar navbar-default navbar-fixed-top" role="navigation">
<div class="container">
<div class="navbar-header">
<button type="button" class="navbar-toggle collapsed" data-toggle="collapse" data-target="#navbar" aria-expanded="false">
<span class="sr-only">Toggle navigation</span>
<span class="icon-bar"></span>
<span class="icon-bar"></span>
<span class="icon-bar"></span>
</button>
<span class="navbar-brand">
<a class="navbar-link" href="index.html">DemoTools</a>
<span class="version label label-default" data-toggle="tooltip" data-placement="bottom" title="Released version">1.2.5</span>
</span>
</div>
<div id="navbar" class="navbar-collapse collapse">
<ul class="nav navbar-nav">
<li>
<a href="index.html">
<span class="fas fa fas fa-home fa-lg"></span>
</a>
</li>
<li>
<a href="reference/index.html">Reference</a>
</li>
<li class="dropdown">
<a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-expanded="false">
Articles
<span class="caret"></span>
</a>
<ul class="dropdown-menu" role="menu">
<li>
<a href="articles/Age-heaping_quality_with_Demotools.html">Age-heaping indices with DemoTools</a>
</li>
<li>
<a href="articles/case_study_1.html">DemoTools: A case study</a>
</li>
<li>
<a href="articles/graduation_with_demotools.html">Graduation with DemoTools</a>
</li>
<li>
<a href="articles/lifetable_with_demotools.html">The lifetable with DemoTools</a>
</li>
<li>
<a href="articles/smoothing_with_demotools.html">Smoothing with DemoTools</a>
</li>
</ul>
</li>
<li>
<a href="news/index.html">Changelog</a>
</li>
</ul>
<ul class="nav navbar-nav navbar-right">
</ul>
</div><!--/.nav-collapse -->
</div><!--/.container -->
</div><!--/.navbar -->
</header>
<div class="row">
<div class="contents col-md-9">
<div class="page-header">
<h1>NA</h1>
</div>
<div id="contributing-to-demotools" class="section level2">
<h2 class="hasAnchor">
<a href="#contributing-to-demotools" class="anchor"></a>Contributing to DemoTools</h2>
<p>The goal of this guide is to help you contribute to <code>DemoTools</code> as quickly and as easily possible. The guide is divided into two main pieces:</p>
<ol>
<li>Filing a bug report or feature request in an <a href="https://github.com/timriffe/DemoTools/issues">issue</a>.</li>
<li>Suggesting a change via a pull request.</li>
</ol>
</div>
<div id="issues" class="section level2">
<h2 class="hasAnchor">
<a href="#issues" class="anchor"></a>Issues</h2>
<p>Before you file an issue:</p>
<ol>
<li><p>Check that you’re using the latest version of <code>DemoTools</code>. It’s quite possible that the problem you’re experiencing has already been fixed.</p></li>
<li><p>Check that the issue belongs in <code>DemoTools</code>. Some functionality lives in separate packages.</p></li>
<li><p>Spend a few minutes looking at the existing issues. It’s possible that your issue has already been filed. But it’s almost always better to open a new issue instead of commenting on an existing issue. The only exception is that you are confident that your issue is identical to an existing problem, and your contribution will help us better understand the general case. It’s generally a bad idea to comment on a closed issue or a commit. Those comments don’t show up in the issue tracker and are easily misplaced.</p></li>
</ol>
<p>When filing an issue, the most important thing is to include a minimal reproducible example so that we can quickly verify the problem, and then figure out how to fix it. There are three things you need to include to make your example reproducible: required packages, data, code.</p>
<ol>
<li><p><strong>Packages</strong> should be loaded at the top of the script, so it’s easy to see which ones the example needs.</p></li>
<li>
<p>The easiest way to include <strong>data</strong> is to use <code><a href="https://rdrr.io/r/base/dput.html">dput()</a></code> to generate the R code to recreate it. For example, to recreate the <code>mtcars</code> dataset in R, I’d perform the following steps:</p>
<ol>
<li>Run <code><a href="https://rdrr.io/r/base/dput.html">dput(mtcars)</a></code> in R</li>
<li>Copy the output</li>
<li>In my reproducible script, type <code>mtcars <-</code> then paste.</li>
</ol>
<p>But even better is if you can create simple objects such as those used in the function examples for most top-level methods in the package.</p>
</li>
<li>
<p>Spend a little bit of time ensuring that your <strong>code</strong> is easy for others to read:</p>
<ul>
<li><p>make sure you’ve used spaces and your variable names are concise, but informative</p></li>
<li><p>use comments to indicate where your problem lies</p></li>
<li><p>do your best to remove everything that is not related to the problem.<br>
The shorter your code is, the easier it is to understand.</p></li>
</ul>
<p>Learn a little [markdown][markdown] so you can correctly format your issue. The most important thing is to surround your code with <code>``` R</code> and <code>```</code> so it’s syntax highlighted (which makes it easier to read).</p>
</li>
<li><p>Check that you’ve actually made a reproducible example by using the <a href="https://github.com/jennybc/reprex">reprex package</a>.</p></li>
</ol>
</div>
<div id="pull-requests" class="section level2">
<h2 class="hasAnchor">
<a href="#pull-requests" class="anchor"></a>Pull requests</h2>
<ul>
<li><p>If you have something to contribute, please <em>fork</em> the repository, make the change in your fork, and then make a pull request.</p></li>
<li><p>Your pull request will be easiest for us to read if you use a common style: <a href="http://r-pkgs.had.co.nz/r.html#style" class="uri">http://r-pkgs.had.co.nz/r.html#style</a>. Please pay particular attention to whitespace.</p></li>
<li><p>You should always add a bullet point to <code>NEWS.md</code> motivating the change. It should look like “This is what changed (@yourusername, #issuenumber)”. Please don’t add headings like “bug fix” or “new features” - these are added during the release process.</p></li>
<li><p>If you can, also write a test.</p></li>
<li><p>If you’re adding new parameters or a new function, you’ll also need to document them with <a href="http://r-pkgs.had.co.nz/man.html">roxygen2</a>. Make sure to re-run <code><a href="https://rdrr.io/pkg/devtools/man/document.html">devtools::document()</a></code> on the code before submitting.</p></li>
<li><p>Also run <code><a href="https://rdrr.io/pkg/devtools/man/check.html">devtools::check()</a></code> to make sure your function doesn’t imply downstream errors or warnings. More such checking will be taken care of by us.</p></li>
<li><p>Here are tips for syncing your fork with the main repository <a href="https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork">syncing</a></p></li>
</ul>
<p>A pull request is a process, and unless you’re a practiced contributor it’s unlikely that your pull request will be accepted as is. Typically the process looks like this:</p>
<ol>
<li><p>You submit the pull request.</p></li>
<li><p>We review at a high-level and determine if this is something that we want to include in the package. If not, we’ll close the pull request and suggest an alternative home for your code.</p></li>
<li><p>We’ll take a closer look at the code and give you feedback.</p></li>
<li><p>You respond to our feedback, update the pull request and add a comment like “PTAL” (please take a look).</p></li>
</ol>
<p>Don’t worry if your pull request isn’t perfect. It’s a learning process and we’ll be happy to help you out.</p>
<p>It can be frustrating that your PR is ignored for some time, but it will eventually make it into the package in one way or another.</p>
</div>
</div>
</div>
<footer>
<div class="copyright">
<p>Developed by .</p>
</div>
<div class="pkgdown">
<p>Site built with <a href="https://pkgdown.r-lib.org/">pkgdown</a> 1.4.1.</p>
</div>
</footer>
</div>
</body>
</html>