diff --git a/go/streamlog/streamlog.go b/go/streamlog/streamlog.go index 30a2b947e2c..d376e5b28ea 100644 --- a/go/streamlog/streamlog.go +++ b/go/streamlog/streamlog.go @@ -261,10 +261,10 @@ func GetFormatter[T any](logger *StreamLogger[T]) LogFormatter { func shouldSampleQuery() bool { if queryLogSampleRate <= 0 { return false - } else if queryLogSampleRate >= 1.0 { + } else if queryLogSampleRate >= 1 { return true } - return rand.Float64() <= queryLogSampleRate + return rand.Float64() < queryLogSampleRate } // ShouldEmitLog returns whether the log with the given SQL query diff --git a/go/streamlog/streamlog_test.go b/go/streamlog/streamlog_test.go index 63beb2e48b1..ff9185a2ccd 100644 --- a/go/streamlog/streamlog_test.go +++ b/go/streamlog/streamlog_test.go @@ -347,15 +347,6 @@ func TestShouldEmitLog(t *testing.T) { rowsReturned: 17, ok: true, }, - { - sql: "this contains out-of-bounds querySampleRate: 123.0", - qLogFilterTag: "", - qLogRowThreshold: 0, - qLogSampleRate: 123.0, - rowsAffected: 7, - rowsReturned: 17, - ok: true, - }, { sql: "this contains querySampleRate: 1.0 without expected queryFilterTag", qLogFilterTag: "TAG",