Skip to content

Commit

Permalink
Use non-deprecated flags to skip replication (vitessio#17400)
Browse files Browse the repository at this point in the history
Signed-off-by: Dirkjan Bussink <[email protected]>
  • Loading branch information
dbussink authored Dec 18, 2024
1 parent 8652490 commit 66e71db
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 7 deletions.
4 changes: 0 additions & 4 deletions config/mycnf/default.cnf
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ secure-file-priv = {{.SecureFilePriv}}

server-id = {{.ServerID}}

# all db instances should skip starting replication threads - that way we can do any
# additional configuration (like enabling semi-sync) before we connect to
# the source.
skip_slave_start
socket = {{.SocketFile}}
tmpdir = {{.TmpDir}}

Expand Down
5 changes: 5 additions & 0 deletions config/mycnf/mariadb10.cnf
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# This file is auto-included when MariaDB 10 is detected.

# all db instances should skip starting replication threads - that way we can do any
# additional configuration (like enabling semi-sync) before we connect to
# the source.
skip_slave_start

# Semi-sync replication is required for automated unplanned failover
# (when the primary goes away). Here we just load the plugin so it's
# available if desired, but it's disabled at startup.
Expand Down
5 changes: 5 additions & 0 deletions config/mycnf/mysql57.cnf
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# This file is auto-included when MySQL 5.7 is detected.

# all db instances should skip starting replication threads - that way we can do any
# additional configuration (like enabling semi-sync) before we connect to
# the source.
skip_slave_start

# MySQL 5.7 does not enable the binary log by default, and
# info repositories default to file

Expand Down
5 changes: 5 additions & 0 deletions config/mycnf/mysql80.cnf
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# This file is auto-included when MySQL 8.0 is detected.

# all db instances should skip starting replication threads - that way we can do any
# additional configuration (like enabling semi-sync) before we connect to
# the source.
skip_slave_start

# MySQL 8.0 enables binlog by default with sync_binlog and TABLE info repositories
# It does not enable GTIDs or enforced GTID consistency

Expand Down
5 changes: 5 additions & 0 deletions config/mycnf/mysql8026.cnf
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# This file is auto-included when MySQL 8.0.26 or later is detected.

# all db instances should skip starting replication threads - that way we can do any
# additional configuration (like enabling semi-sync) before we connect to
# the source.
skip_replica_start

# MySQL 8.0 enables binlog by default with sync_binlog and TABLE info repositories
# It does not enable GTIDs or enforced GTID consistency

Expand Down
5 changes: 5 additions & 0 deletions config/mycnf/mysql84.cnf
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# This file is auto-included when MySQL 8.4.0 or later is detected.

# all db instances should skip starting replication threads - that way we can do any
# additional configuration (like enabling semi-sync) before we connect to
# the source.
skip_replica_start

# MySQL 8.0 enables binlog by default with sync_binlog and TABLE info repositories
# It does not enable GTIDs or enforced GTID consistency

Expand Down
3 changes: 0 additions & 3 deletions config/mycnf/sbr.cnf

This file was deleted.

0 comments on commit 66e71db

Please sign in to comment.