improve tests again

Signed-off-by: Tim Vaillancourt <[email protected]>
timvaillancourt · Oct 2, 2024 · d21b97a · d21b97a
1 parent 3483efc
commit d21b97a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/go/vt/vtctl/reparentutil/emergency_reparenter_test.go b/go/vt/vtctl/reparentutil/emergency_reparenter_test.go
@@ -1900,7 +1900,7 @@ func TestEmergencyReparenter_reparentShardLocked(t *testing.T) {
 			err := erp.reparentShardLocked(ctx, ev, tt.keyspace, tt.shard, tt.emergencyReparentOps)
 			if tt.shouldErr {
 				assert.Error(t, err)
-				assert.Contains(t, err.Error(), tt.errShouldContain)
+				assert.ErrorContains(t, err, tt.errShouldContain)
 				return
 			}
 

diff --git a/go/vt/vtctl/reparentutil/planned_reparenter_flaky_test.go b/go/vt/vtctl/reparentutil/planned_reparenter_flaky_test.go
@@ -3396,7 +3396,7 @@ func TestPlannedReparenter_reparentShardLocked(t *testing.T) {
 			if tt.shouldErr {
 				assert.Error(t, err)
 				if tt.errShouldContain != "" {
-					assert.Contains(t, err.Error(), tt.errShouldContain)
+					assert.ErrorContains(t, err, tt.errShouldContain)
 				}
 				return
 			}